Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: cc/frame_rate_counter.h

Issue 11232051: Remove static thread pointers from CC (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Apply code review comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/font_atlas.cc ('k') | cc/frame_rate_counter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_FRAME_RATE_COUNTER_H_ 5 #ifndef CC_FRAME_RATE_COUNTER_H_
6 #define CC_FRAME_RATE_COUNTER_H_ 6 #define CC_FRAME_RATE_COUNTER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/time.h" 10 #include "base/time.h"
11 11
12 namespace cc { 12 namespace cc {
13 13
14 // This class maintains a history of timestamps, and provides functionality to 14 // This class maintains a history of timestamps, and provides functionality to
15 // intelligently compute average frames per second (and standard deviation). 15 // intelligently compute average frames per second (and standard deviation).
16 class FrameRateCounter { 16 class FrameRateCounter {
17 public: 17 public:
18 static scoped_ptr<FrameRateCounter> create(); 18 static scoped_ptr<FrameRateCounter> create(bool hasImplThread);
19 19
20 void markBeginningOfFrame(base::TimeTicks timestamp); 20 void markBeginningOfFrame(base::TimeTicks timestamp);
21 void markEndOfFrame(); 21 void markEndOfFrame();
22 int currentFrameNumber() const { return m_currentFrameNumber; } 22 int currentFrameNumber() const { return m_currentFrameNumber; }
23 void getAverageFPSAndStandardDeviation(double& averageFPS, double& standardD eviation) const; 23 void getAverageFPSAndStandardDeviation(double& averageFPS, double& standardD eviation) const;
24 int timeStampHistorySize() const { return kTimeStampHistorySize; } 24 int timeStampHistorySize() const { return kTimeStampHistorySize; }
25 25
26 // n = 0 returns the oldest frame retained in the history, 26 // n = 0 returns the oldest frame retained in the history,
27 // while n = timeStampHistorySize() - 1 returns the timestamp most recent fr ame. 27 // while n = timeStampHistorySize() - 1 returns the timestamp most recent fr ame.
28 // FIXME: Returns most recent timestamp for n = 0 when called between markBe ginningOfFrame and markEndOfFrame calls. 28 // FIXME: Returns most recent timestamp for n = 0 when called between markBe ginningOfFrame and markEndOfFrame calls.
29 base::TimeTicks timeStampOfRecentFrame(int n) const; 29 base::TimeTicks timeStampOfRecentFrame(int n) const;
30 30
31 // This is a heuristic that can be used to ignore frames in a reasonable way . Returns 31 // This is a heuristic that can be used to ignore frames in a reasonable way . Returns
32 // true if the given frame interval is too fast or too slow, based on consta nt thresholds. 32 // true if the given frame interval is too fast or too slow, based on consta nt thresholds.
33 bool isBadFrameInterval(base::TimeDelta intervalBetweenConsecutiveFrames) co nst; 33 bool isBadFrameInterval(base::TimeDelta intervalBetweenConsecutiveFrames) co nst;
34 34
35 int droppedFrameCount() const { return m_droppedFrameCount; } 35 int droppedFrameCount() const { return m_droppedFrameCount; }
36 36
37 private: 37 private:
38 FrameRateCounter(); 38 explicit FrameRateCounter(bool hasImplThread);
39 39
40 base::TimeDelta frameInterval(int frameNumber) const; 40 base::TimeDelta frameInterval(int frameNumber) const;
41 int frameIndex(int frameNumber) const; 41 int frameIndex(int frameNumber) const;
42 bool isBadFrame(int frameNumber) const; 42 bool isBadFrame(int frameNumber) const;
43 43
44 // Two thresholds (measured in seconds) that describe what is considered to be a "no-op frame" that should not be counted. 44 // Two thresholds (measured in seconds) that describe what is considered to be a "no-op frame" that should not be counted.
45 // - if the frame is too fast, then given our compositor implementation, the frame probably was a no-op and did not draw. 45 // - if the frame is too fast, then given our compositor implementation, the frame probably was a no-op and did not draw.
46 // - if the frame is too slow, then there is probably not animating content, so we should not pollute the average. 46 // - if the frame is too slow, then there is probably not animating content, so we should not pollute the average.
47 static const double kFrameTooFast; 47 static const double kFrameTooFast;
48 static const double kFrameTooSlow; 48 static const double kFrameTooSlow;
49 49
50 // If a frame takes longer than this threshold (measured in seconds) then we 50 // If a frame takes longer than this threshold (measured in seconds) then we
51 // (naively) assume that it missed a screen refresh; that is, we dropped a f rame. 51 // (naively) assume that it missed a screen refresh; that is, we dropped a f rame.
52 // FIXME: Determine this threshold based on monitor refresh rate, crbug.com/ 138642. 52 // FIXME: Determine this threshold based on monitor refresh rate, crbug.com/ 138642.
53 static const double kDroppedFrameTime; 53 static const double kDroppedFrameTime;
54 54
55 static const int kTimeStampHistorySize = 170; 55 static const int kTimeStampHistorySize = 170;
56 56
57 bool m_hasImplThread;
58
57 int m_currentFrameNumber; 59 int m_currentFrameNumber;
58 base::TimeTicks m_timeStampHistory[kTimeStampHistorySize]; 60 base::TimeTicks m_timeStampHistory[kTimeStampHistorySize];
59 61
60 int m_droppedFrameCount; 62 int m_droppedFrameCount;
61 63
62 DISALLOW_COPY_AND_ASSIGN(FrameRateCounter); 64 DISALLOW_COPY_AND_ASSIGN(FrameRateCounter);
63 }; 65 };
64 66
65 } // namespace cc 67 } // namespace cc
66 68
67 #endif // CC_FRAME_RATE_COUNTER_H_ 69 #endif // CC_FRAME_RATE_COUNTER_H_
OLDNEW
« no previous file with comments | « cc/font_atlas.cc ('k') | cc/frame_rate_counter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698