Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1471)

Issue 11232046: Add fifth batch of controlled setting indicators (Closed)

Created:
8 years, 2 months ago by bartfab (slow)
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add fifth batch of controlled setting indicators This CL continues the addition of controlled setting indicators to the Chrome settings UI. BUG=104955 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164055

Patch Set 1 #

Total comments: 3

Patch Set 2 : Refactored on top of new CL 11232059, removing the need for any JS changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -52 lines) Patch
M chrome/app/policy/policy_templates.json View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 5 chunks +55 lines, -18 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.html View 2 chunks +58 lines, -20 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 6 chunks +58 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bartfab (slow)
Hi James, could you take a look at the UI part of this CL? Hi ...
8 years, 2 months ago (2012-10-22 18:23:50 UTC) #1
Joao da Silva
policy/ lgtm https://codereview.chromium.org/11232046/diff/1/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (right): https://codereview.chromium.org/11232046/diff/1/chrome/browser/resources/options/browser_options.js#newcode182 chrome/browser/resources/options/browser_options.js:182: }); Shouldn't this be handled by the ...
8 years, 2 months ago (2012-10-22 20:47:38 UTC) #2
bartfab (slow)
https://chromiumcodereview.appspot.com/11232046/diff/1/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (right): https://chromiumcodereview.appspot.com/11232046/diff/1/chrome/browser/resources/options/browser_options.js#newcode182 chrome/browser/resources/options/browser_options.js:182: }); Thanks for the comments. They motivated me to ...
8 years, 2 months ago (2012-10-23 10:28:31 UTC) #3
bartfab (slow)
Hi James, since you reviewed a later CL today, I am wondering whether this older ...
8 years, 2 months ago (2012-10-24 18:15:13 UTC) #4
James Hawkins
lgtm
8 years, 2 months ago (2012-10-24 18:16:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11232046/5001
8 years, 2 months ago (2012-10-24 18:39:48 UTC) #6
commit-bot: I haz the power
Presubmit check for 11232046-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-24 18:39:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11232046/5001
8 years, 1 month ago (2012-10-25 10:33:05 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 12:45:01 UTC) #9
Change committed as 164055

Powered by Google App Engine
This is Rietveld 408576698