Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11232014: Move a bunch of code in content\renderer to the content namespace. (Closed)

Created:
8 years, 2 months ago by jam
Modified:
8 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org, dcheng
Visibility:
Public.

Description

Move a bunch of code in content\renderer to the content namespace. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163061

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix linux #

Patch Set 3 : fix mac and sync #

Patch Set 4 : fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+890 lines, -672 lines) Patch
M content/app/content_main_runner.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M content/public/test/render_view_fake_resources_test.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/device_orientation_dispatcher.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/device_orientation_dispatcher.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M content/renderer/devtools_agent.h View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M content/renderer/devtools_agent.cc View 1 2 5 chunks +10 lines, -7 lines 0 comments Download
M content/renderer/devtools_agent_filter.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/devtools_agent_filter.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/devtools_client.h View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/devtools_client.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/do_not_track_bindings.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/dom_storage/dom_storage_dispatcher.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/dom_storage/dom_storage_dispatcher.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/dom_storage/webstoragearea_impl.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/dom_storage/webstoragearea_impl.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/dom_storage/webstoragenamespace_impl.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/dom_storage/webstoragenamespace_impl.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/external_popup_menu.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/external_popup_menu.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/external_popup_menu_browsertest.cc View 1 2 3 4 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/geolocation_dispatcher.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/geolocation_dispatcher.cc View 1 2 4 chunks +8 lines, -4 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_thread.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_thread.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/idle_user_detector.h View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/idle_user_detector.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M content/renderer/input_tag_speech_dispatcher.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/input_tag_speech_dispatcher.cc View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/load_progress_tracker.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/load_progress_tracker.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/media/audio_hardware.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.h View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 1 2 5 chunks +10 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_extra_data.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_impl.h View 1 2 5 chunks +8 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 1 2 8 chunks +16 lines, -14 lines 0 comments Download
M content/renderer/media/media_stream_impl_unittest.cc View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 1 2 4 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/media/peer_connection_handler_base.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/peer_connection_handler_jsep_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/pepper_platform_video_decoder_impl.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/media/pepper_platform_video_decoder_impl.cc View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/media/render_audiosourceprovider.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/render_audiosourceprovider.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/render_media_log.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/render_media_log.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_unittest.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/mhtml_generator.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/mhtml_generator.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/mouse_lock_dispatcher.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/mouse_lock_dispatcher.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/mouse_lock_dispatcher_browsertest.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/notification_provider.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/notification_provider.cc View 1 2 4 chunks +8 lines, -3 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/pepper/content_renderer_pepper_host_factory.h View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_file_chooser_host.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 14 chunks +28 lines, -31 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 21 chunks +29 lines, -34 lines 0 comments Download
M content/renderer/render_thread_impl_unittest.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 16 chunks +36 lines, -36 lines 0 comments Download
M content/renderer/render_view_browsertest_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 33 chunks +80 lines, -97 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 85 chunks +129 lines, -147 lines 0 comments Download
M content/renderer/render_view_linux.cc View 1 2 6 chunks +34 lines, -30 lines 0 comments Download
M content/renderer/render_view_mouse_lock_dispatcher.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/render_view_mouse_lock_dispatcher.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 2 8 chunks +8 lines, -15 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_widget_fullscreen.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 5 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/renderer_accessibility.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/renderer_accessibility_browsertest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/renderer_accessibility_complete.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/renderer_clipboard_client.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/renderer_clipboard_client.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/renderer_main.cc View 1 2 5 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/renderer_webapplicationcachehost_impl.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_webapplicationcachehost_impl.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/renderer_webcolorchooser_impl.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/renderer_webcolorchooser_impl.cc View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M content/renderer/renderer_webcookiejar_impl.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_webcookiejar_impl.cc View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 2 chunks +9 lines, -8 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 11 chunks +13 lines, -12 lines 0 comments Download
M content/renderer/speech_recognition_dispatcher.h View 1 2 3 chunks +6 lines, -8 lines 0 comments Download
M content/renderer/speech_recognition_dispatcher.cc View 1 2 6 chunks +16 lines, -15 lines 0 comments Download
M content/renderer/text_input_client_observer.h View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/text_input_client_observer.cc View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/web_intents_host.h View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/web_intents_host.cc View 1 2 5 chunks +7 lines, -4 lines 0 comments Download
M content/renderer/web_intents_host_browsertest.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.h View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 2 5 chunks +8 lines, -4 lines 0 comments Download
M content/test/webrtc_audio_device_test.h View 1 2 3 chunks +10 lines, -9 lines 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 2 10 chunks +23 lines, -24 lines 0 comments Download
M webkit/plugins/ppapi/fullscreen_container.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
I did this while waiting for your http://codereview.chromium.org/11146023/ to land :)
8 years, 2 months ago (2012-10-19 19:35:43 UTC) #1
scottmg
8 years, 2 months ago (2012-10-19 19:46:34 UTC) #2 
lgtm if it builds.

(Are you waiting on that other change for some reason? There's something wrong
on linux_chromeos that I don't understand so it might be a little while)

https://codereview.chromium.org/11232014/diff/1/content/renderer/render_view_...
File content/renderer/render_view_impl.h (left):

https://codereview.chromium.org/11232014/diff/1/content/renderer/render_view_...
content/renderer/render_view_impl.h:12: #include <vector>
yikes

Powered by Google App Engine
This is Rietveld 408576698