Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: chrome/test/data/extensions/platform_apps/browser_tag/main.js

Issue 11231086: Remove width and height property from <webview> tag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update the tests, less timeouts. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/platform_apps/browser_tag/main.js
diff --git a/chrome/test/data/extensions/platform_apps/browser_tag/main.js b/chrome/test/data/extensions/platform_apps/browser_tag/main.js
index b212352a83e9cbe9e7d0d59f4c911c1a6f36a7ac..aee53ebb759f046d9db8bc4cbc8f64d4d00eb5f0 100644
--- a/chrome/test/data/extensions/platform_apps/browser_tag/main.js
+++ b/chrome/test/data/extensions/platform_apps/browser_tag/main.js
@@ -12,41 +12,30 @@ onload = function() {
chrome.test.assertEq(300, browserTag.offsetWidth);
chrome.test.assertEq(200, browserTag.offsetHeight);
- browserTag.setAttribute('width', 310);
- browserTag.setAttribute('height', 210);
+ browserTag.style.width = '310px';
+ browserTag.style.height = '210px';
+
+ chrome.test.assertEq(310, browserTag.offsetWidth);
+ chrome.test.assertEq(210, browserTag.offsetHeight);
+
+ browserTag.style.width = '320px';
+ browserTag.style.height = '220px';
+
+ chrome.test.assertEq(320, browserTag.offsetWidth);
+ chrome.test.assertEq(220, browserTag.offsetHeight);
+
+ var dynamicBrowserTag = document.createElement('browser');
+ dynamicBrowserTag.setAttribute('src', 'data:text/html,dynamic browser');
+ dynamicBrowserTag.style.width = '330px';
+ dynamicBrowserTag.style.height = '230px';
+ document.body.appendChild(dynamicBrowserTag);
// Timeout is necessary to give the mutation observers a chance to fire.
setTimeout(function() {
- chrome.test.assertEq(310, browserTag.offsetWidth);
- chrome.test.assertEq(210, browserTag.offsetHeight);
-
- // Should also be able to query/update the dimensions via getterts/
- // setters.
- chrome.test.assertEq(310, browserTag.width);
- chrome.test.assertEq(210, browserTag.height);
-
- browserTag.width = 320;
- browserTag.height = 220;
-
- // Setters also end up operating via mutation observers.
- setTimeout(function() {
- chrome.test.assertEq(320, browserTag.offsetWidth);
- chrome.test.assertEq(220, browserTag.offsetHeight);
-
- var dynamicBrowserTag = document.createElement('browser');
- dynamicBrowserTag.setAttribute(
- 'src', 'data:text/html,dynamic browser');
- dynamicBrowserTag.setAttribute('width', '330');
- dynamicBrowserTag.setAttribute('height', '230');
- document.body.appendChild(dynamicBrowserTag);
-
- setTimeout(function() {
- chrome.test.assertEq(330, dynamicBrowserTag.offsetWidth);
- chrome.test.assertEq(230, dynamicBrowserTag.offsetHeight);
-
- chrome.test.succeed();
- }, 0);
- }, 0);
+ chrome.test.assertEq(330, dynamicBrowserTag.offsetWidth);
+ chrome.test.assertEq(230, dynamicBrowserTag.offsetHeight);
+
+ chrome.test.succeed();
}, 0);
},

Powered by Google App Engine
This is Rietveld 408576698