Issue 11231048: Fix the build bot by removing the flag for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11231048: Fix the build bot by removing the flag for Android (Closed)

Created:
8 years, 2 months ago by michaelbai

Modified:
8 years, 2 months ago

Reviewers:
Yaron, Isaac (away)

CC:
chromium-reviews, bulach, Nico

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the build bot by removing the flag for Android Remove the cflag '-Wno-tautological-constant-out-of-range-compare' for Android BUG=157026 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163400

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	build/common.gypi	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm http://codereview.chromium.org/11231048/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/11231048/diff/1/build/common.gypi#newcode2529 build/common.gypi:2529: '-Wno-tautological-constant-out-of-range-compare', Please file a bug to follow-up on ...

8 years, 2 months ago (2012-10-22 18:37:30 UTC) #2

michaelbai

On 2012/10/22 18:37:30, Yaron wrote: > lgtm > > http://codereview.chromium.org/11231048/diff/1/build/common.gypi > File build/common.gypi (right): > ...

8 years, 2 months ago (2012-10-22 18:47:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11231048/5001

8 years, 2 months ago (2012-10-22 18:48:05 UTC) #4

Change committed as 163400

Expand Messages | Collapse Messages