Issue 11231033: Handle null Extension*s in AppRestoreService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11231033: Handle null Extension*s in AppRestoreService. (Closed)

Created:
8 years, 2 months ago by koz (OOO until 15th September)

Modified:
8 years, 2 months ago

Reviewers:
benwells

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Handle null Extension*s in AppRestoreService. BUG=155871 TBR=benwells@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163204

Patch Set 2 : rephrase #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/extensions/app_restore_service.cc	View	1	1 chunk	+3 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/11231033/2001

8 years, 2 months ago (2012-10-21 05:58:36 UTC) #1

benwells

https://chromiumcodereview.appspot.com/11231033/diff/2001/chrome/browser/extensions/app_restore_service.cc File chrome/browser/extensions/app_restore_service.cc (right): https://chromiumcodereview.appspot.com/11231033/diff/2001/chrome/browser/extensions/app_restore_service.cc#newcode69 chrome/browser/extensions/app_restore_service.cc:69: if (host->extension()->is_platform_app()) { Is the NULL check needed here ...

8 years, 2 months ago (2012-10-22 00:07:56 UTC) #3

koz (OOO until 15th September)

8 years, 2 months ago (2012-10-25 03:49:47 UTC) #4

https://chromiumcodereview.appspot.com/11231033/diff/2001/chrome/browser/exte...
File chrome/browser/extensions/app_restore_service.cc (right):

https://chromiumcodereview.appspot.com/11231033/diff/2001/chrome/browser/exte...
chrome/browser/extensions/app_restore_service.cc:69: if
(host->extension()->is_platform_app()) {
On 2012/10/22 00:07:56, benwells wrote:
> Is the NULL check needed here as well?

Yes, it is. Seeing as this patch has already landed and I'm in China (and
therefore unable to really do work) could you add the check for me?

Expand Messages | Collapse Messages

Issue 11231033: Handle null Extension*s in AppRestoreService. (Closed)

Description

Patch Set 1 #

Patch Set 2 : rephrase #

Messages