Add a mechanism to provide non-linear scaling of fling acceleration.

Add a mechanism to provide non-linear scaling of fling acceleration.

touchscreen fling is too slow at high velocities. This patch addes a
facility to permit adjusting the fling acceleration multiplier
differently across a uniform range of fling velocities so that fast
flings can go extra fast and slow flings will be gentle.

BUG=141653
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163693

[rjkroege, 2012-10-19 22:41:23]

Makes touchscreen fling controlled by a table. Please take a look.

[sadrul, 2012-10-20 01:28:51]

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
File ui/base/gestures/gesture_sequence.cc (right):

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:299: static void
SetDefaultFlingVelocityScaling() {
I think functions in anonymous namespace don't need to be declared static

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:310: if (did_setup_scaling)
Make |did_setup_scaling| a local static variable in this function?

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:320: char* s = pk;
Perhaps use StringTokenizer (base/string_tokenizer.h) and base::StringToDouble
(base/string_number_conversions.h)?

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:332: float abs_velocity = (velocity < 0) ?
velocity * -1: velocity;
abs_velocity = fabs(velocity)?

[rjkroege, 2012-10-22 15:21:33]

ptal.

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
File ui/base/gestures/gesture_sequence.cc (right):

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:299: static void
SetDefaultFlingVelocityScaling() {
On 2012/10/20 01:28:51, sadrul wrote:
> I think functions in anonymous namespace don't need to be declared static

Done.

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:310: if (did_setup_scaling)
On 2012/10/20 01:28:51, sadrul wrote:
> Make |did_setup_scaling| a local static variable in this function?

Done.

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:320: char* s = pk;
On 2012/10/20 01:28:51, sadrul wrote:
> Perhaps use StringTokenizer (base/string_tokenizer.h) and base::StringToDouble
> (base/string_number_conversions.h)?

Is this really an improvement? :-)

Done.

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:320: char* s = pk;
On 2012/10/20 01:28:51, sadrul wrote:
> Perhaps use StringTokenizer (base/string_tokenizer.h) and base::StringToDouble
> (base/string_number_conversions.h)?

Done.

http://codereview.chromium.org/11231018/diff/1/ui/base/gestures/gesture_seque...
ui/base/gestures/gesture_sequence.cc:332: float abs_velocity = (velocity < 0) ?
velocity * -1: velocity;
On 2012/10/20 01:28:51, sadrul wrote:
> abs_velocity = fabs(velocity)?

Done.

[sadrul, 2012-10-22 16:24:28]

LGTM

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
File ui/base/gestures/gesture_sequence.cc (right):

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:8: #include <stdio.h>
This isn't needed anymore.

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:13: #include "base//string_tokenizer.h"
// -> /

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:314: LOG(WARNING) << "Could not read
configuration var. defaulting.\n";
This might show up in the test output, and will cause sadness among folks. I
think removing this makes sense (or logging when the config is read from the
env-var instead). And perhaps INFO is better suited than WARNING

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:322: if (base::StringToDouble(t.token(),
&d))
Braces (in chrome, if any of the if/else requires braces, then all of it should
have them (a difference from WebKit land)).

[rjkroege, 2012-10-23 19:10:52]

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
File ui/base/gestures/gesture_sequence.cc (right):

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:8: #include <stdio.h>
On 2012/10/22 16:24:28, sadrul wrote:
> This isn't needed anymore.

stdlib is needed for getenv. Changed.

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:13: #include "base//string_tokenizer.h"
On 2012/10/22 16:24:28, sadrul wrote:
> // -> /

Done.

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:314: LOG(WARNING) << "Could not read
configuration var. defaulting.\n";
On 2012/10/22 16:24:28, sadrul wrote:
> This might show up in the test output, and will cause sadness among folks. I
> think removing this makes sense (or logging when the config is read from the
> env-var instead). And perhaps INFO is better suited than WARNING

Done.

http://codereview.chromium.org/11231018/diff/4001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:322: if (base::StringToDouble(t.token(),
&d))
On 2012/10/22 16:24:28, sadrul wrote:
> Braces (in chrome, if any of the if/else requires braces, then all of it
should
> have them (a difference from WebKit land)).

Done. I like Chrome land better.

[commit-bot: I haz the power, 2012-10-23 19:11:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rjkroege@chromium.org/11231018/2004

[commit-bot: I haz the power, 2012-10-23 22:02:55]

Change committed as 163693