chrome/browser/autofill/autofill_download_url.h - Issue 11230060: Adding commandline switch and user pref for autofill server url.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/autofill/autofill_download_url.h

Issue 11230060: Adding commandline switch and user pref for autofill server url. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removing pref for autofill server url Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/autofill/autofill_download.cc ('k') | chrome/browser/autofill/autofill_download_url.cc » ('j') | chrome/browser/autofill/autofill_download_url_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_URL_H_

	6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_URL_H_

	7

	8 #include <string>
	Ilya Sherman 2012/10/26 00:10:49 nit: Once GetBaseAutofillUrl() is moved into the i nit: Once GetBaseAutofillUrl() is moved into the implementation file, this import can be moved as well. ahutter 2012/10/29 15:38:13 Done. Show quoted text On 2012/10/26 00:10:49, Ilya Sherman wrote: > nit: Once GetBaseAutofillUrl() is moved into the implementation file, this > import can be moved as well. Done.
	9

	10 #include "base/basictypes.h"

	11

	12 class GURL;

	13

	14 class AutofillDownloadUrl {
	Ilya Sherman 2012/10/26 00:10:49 This class is now stateless, which means that the This class is now stateless, which means that the methods it exposes can now simply be free functions (probably enclosed in an "autofill" namespace). ahutter 2012/10/29 15:38:13 Done. Show quoted text On 2012/10/26 00:10:49, Ilya Sherman wrote: > This class is now stateless, which means that the methods it exposes can now > simply be free functions (probably enclosed in an "autofill" namespace). Done.
	15 public:

	16 AutofillDownloadUrl() {}

	17 GURL GetAutofillQueryUrl();

	18 GURL GetAutofillUploadUrl();

	19

	20 private:

	21 std::string GetBaseAutofillUrl();
	Ilya Sherman 2012/10/26 00:10:49 nit: This can now be tucked into an anonymous name nit: This can now be tucked into an anonymous namespace in the implementation file. ahutter 2012/10/29 15:38:13 Done. Show quoted text On 2012/10/26 00:10:49, Ilya Sherman wrote: > nit: This can now be tucked into an anonymous namespace in the implementation > file. Done.
	22

	23 DISALLOW_COPY_AND_ASSIGN(AutofillDownloadUrl);

	24 };

	25

	26 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_URL_H_

	27

OLD	NEW