Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 11230022: webkit: Merge build target 'appcache' to 'webkit_storage' (Closed)

Created:
8 years, 2 months ago by hashimoto
Modified:
8 years, 2 months ago
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, pam+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

webkit: Merge build target 'appcache' to 'webkit_storage' BUG=155242 TEST=build TBR=darin@chromium.org for trivial gyp changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163491

Patch Set 1 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -192 lines) Patch
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M webkit/appcache/appcache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_backend_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_database.h View 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_disk_cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
D webkit/appcache/appcache_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M webkit/appcache/appcache_frontend_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_group.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_host.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/appcache/appcache_interceptor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_interfaces.h View 7 chunks +7 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_quota_client.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/appcache/appcache_request_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_response.h View 6 chunks +6 lines, -6 lines 0 comments Download
M webkit/appcache/appcache_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_storage.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/appcache/appcache_storage_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_update_job.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_working_set.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/appcache/manifest_parser.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/appcache/view_appcache_internals_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/appcache/web_application_cache_host_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/webkit_appcache.gypi View 1 chunk +51 lines, -85 lines 0 comments Download
M webkit/storage/webkit_storage.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
michaeln@, Could you review this change?
8 years, 2 months ago (2012-10-22 08:03:36 UTC) #1
michaeln
LGTM, thnx for merging these things!
8 years, 2 months ago (2012-10-22 19:03:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11230022/2002
8 years, 2 months ago (2012-10-23 00:59:43 UTC) #3
commit-bot: I haz the power
Presubmit check for 11230022-2002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-23 00:59:55 UTC) #4
hashimoto
On 2012/10/22 19:03:59, michaeln wrote: > LGTM, thnx for merging these things! Thanks for reviewing. ...
8 years, 2 months ago (2012-10-23 01:02:24 UTC) #5
hashimoto
TBR-ing darin@ for trivial gyp changes.
8 years, 2 months ago (2012-10-23 01:24:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11230022/2002
8 years, 2 months ago (2012-10-23 01:27:27 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-23 04:18:42 UTC) #8
Change committed as 163491

Powered by Google App Engine
This is Rietveld 408576698