Issue 11230014: Use UMA_HISTOGRAM_ENUMERATION instead of UMA_HISTOGRAM_BOOLEAN

Issue 11230014: Use UMA_HISTOGRAM_ENUMERATION instead of UMA_HISTOGRAM_BOOLEAN (Closed)

Created:
8 years, 2 months ago by achuithb

Modified:
8 years, 2 months ago

Reviewers:
SteveT, Dan Beam

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Use UMA_HISTOGRAM_ENUMERATION instead of UMA_HISTOGRAM_BOOLEAN Also, add a counter for notification promo link clicks. BUG=150886 TEST=manual

Patch Set 2 : PROMO_VIEWED as baseline #

Patch Set 3 : set PROMO_VIEWED to 0 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -9 lines)			Patch
M	chrome/browser/resources/ntp4/new_tab.js	View		2 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_page_handler.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_page_handler.cc	View	1 2	4 chunks	+32 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

lgtm http://codereview.chromium.org/11230014/diff/1/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc File chrome/browser/ui/webui/ntp/new_tab_page_handler.cc (right): http://codereview.chromium.org/11230014/diff/1/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc#newcode32 chrome/browser/ui/webui/ntp/new_tab_page_handler.cc:32: PROMO_VIEWED, nit: you probably want PROMO_VIEWED first in ...

8 years, 2 months ago (2012-10-20 00:50:19 UTC) #2

achuithb

Thanks for the review, Dan! http://codereview.chromium.org/11230014/diff/1/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc File chrome/browser/ui/webui/ntp/new_tab_page_handler.cc (right): http://codereview.chromium.org/11230014/diff/1/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc#newcode32 chrome/browser/ui/webui/ntp/new_tab_page_handler.cc:32: PROMO_VIEWED, On 2012/10/20 00:50:19, ...

8 years, 2 months ago (2012-10-20 18:30:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/11230014/5001

8 years, 2 months ago (2012-10-20 18:30:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/11230014/2004

8 years, 2 months ago (2012-10-20 18:38:17 UTC) #5

Change committed as 163188

Expand Messages | Collapse Messages