Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11230005: Move non-trivial methods from QuicDataWriter to the .cc file (Closed)

Created:
8 years, 2 months ago by Ryan Hamilton
Modified:
8 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move non-trivial methods from QuicDataWriter to the .cc file. Remove the unused AdvancePointer method. Merge internal change 35490203 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163185

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : GG_UINT64_C #

Patch Set 4 : Fix WriteUInt128 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -48 lines) Patch
M net/quic/quic_data_writer.h View 1 chunk +9 lines, -40 lines 0 comments Download
M net/quic/quic_data_writer.cc View 1 2 3 3 chunks +45 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ryan Hamilton
8 years, 2 months ago (2012-10-19 16:29:46 UTC) #1
jar (doing other things)
lgtm
8 years, 2 months ago (2012-10-19 17:55:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11230005/1
8 years, 2 months ago (2012-10-19 18:02:06 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-19 18:55:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11230005/3002
8 years, 2 months ago (2012-10-19 18:59:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11230005/6004
8 years, 2 months ago (2012-10-19 19:31:17 UTC) #6
commit-bot: I haz the power
Retried try job too often for step(s) net_unittests
8 years, 2 months ago (2012-10-19 20:53:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11230005/11004
8 years, 2 months ago (2012-10-19 20:59:54 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-19 21:22:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11230005/11004
8 years, 2 months ago (2012-10-19 22:27:36 UTC) #10
commit-bot: I haz the power
8 years, 2 months ago (2012-10-20 19:46:56 UTC) #11 
Change committed as 163185

Powered by Google App Engine
This is Rietveld 408576698