Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 11229041: Rename and move Ash window frame files (Closed)

Created:
8 years, 2 months ago by James Cook
Modified:
8 years, 2 months ago
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Rename and move Ash window frame files * AppNonClientFrameViewAura is Ash-specific, rename to AppNonClientFrameViewAsh * Move BrowserNonClientFrameViewAsh into chrome/browser/ui/views/frame/ with all the other views platform-specific frames * Add build rule to exclude _ash_browsertests for non-Ash builds BUG=156361 TEST=compiles, browser_tests *NonClientFrameView* pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1464 lines) Patch
M build/filename_rules.gypi View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc View 1 chunk +0 lines, -635 lines 0 comments Download
D chrome/browser/ui/views/ash/browser_non_client_frame_view_ash_browsertest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
A + chrome/browser/ui/views/frame/app_non_client_frame_view_ash.h View 3 chunks +8 lines, -10 lines 0 comments Download
A + chrome/browser/ui/views/frame/app_non_client_frame_view_ash.cc View 8 chunks +30 lines, -37 lines 0 comments Download
A + chrome/browser/ui/views/frame/app_non_client_frame_view_ash_browsertest.cc View 10 chunks +16 lines, -19 lines 0 comments Download
D chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc View 1 chunk +0 lines, -273 lines 0 comments Download
D chrome/browser/ui/views/frame/app_non_client_frame_view_aura_browsertest.cc View 1 chunk +0 lines, -229 lines 0 comments Download
A + chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Ben, PTAL. This is the file move/rename for Ash window frames I talked to you ...
8 years, 2 months ago (2012-10-22 20:49:29 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 2 months ago (2012-10-22 20:51:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11229041/1
8 years, 2 months ago (2012-10-22 22:50:56 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-23 01:09:04 UTC) #4
Change committed as 163466

Powered by Google App Engine
This is Rietveld 408576698