Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 11229022: Move ash/system/web_notification message_center to ui/ (Closed)

Created:
8 years, 2 months ago by stevenjb
Modified:
8 years, 1 month ago
CC:
chromium-reviews, msw+watch_chromium.org, sadrul, ben+watch_chromium.org, tfarina, oshima+watch_chromium.org, alicet1, jshin+watch_chromium.org, vadimt
Visibility:
Public.

Description

Move ash/system/web_notification message_center to ui/ This CL is dependent on http://codereview.chromium.org/11189099/ This will complete the migration of the message center code from Ash to UI so that it can be used on other Views platforms. BUG=150872 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164857

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Remove aura dependency in tray_bubble_view #

Patch Set 5 : Fix win_aura #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase + merge fix for CL: 11308019 #

Patch Set 9 : Rebase again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -2626 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 6 7 5 chunks +3 lines, -16 lines 0 comments Download
M ash/ash_strings.grd View 1 2 3 4 5 6 7 1 chunk +0 lines, -15 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
D ash/resources/default_100_percent/common/status_notify_x.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D ash/resources/default_200_percent/common/status_notify_x.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/system/tray/system_tray.h View 1 2 3 4 5 6 4 chunks +4 lines, -5 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_bubble.h View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_background_view.h View 1 2 3 4 5 6 4 chunks +8 lines, -6 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 2 3 4 5 6 7 8 4 chunks +18 lines, -1 line 0 comments Download
D ash/system/tray/tray_bubble_view.h View 1 chunk +0 lines, -171 lines 0 comments Download
D ash/system/tray/tray_bubble_view.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -401 lines 0 comments Download
M ash/system/tray/tray_bubble_wrapper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/tray/tray_bubble_wrapper.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -4 lines 0 comments Download
M ash/system/tray/tray_event_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/tray_notification_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D ash/system/web_notification/message_center.h View 1 chunk +0 lines, -124 lines 0 comments Download
D ash/system/web_notification/message_center.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D ash/system/web_notification/message_center_bubble.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ash/system/web_notification/message_center_bubble.cc View 1 chunk +0 lines, -304 lines 0 comments Download
D ash/system/web_notification/popup_bubble.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ash/system/web_notification/popup_bubble.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D ash/system/web_notification/web_notification.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ash/system/web_notification/web_notification.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D ash/system/web_notification/web_notification_bubble.h View 1 chunk +0 lines, -71 lines 0 comments Download
D ash/system/web_notification/web_notification_bubble.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D ash/system/web_notification/web_notification_list.h View 1 chunk +0 lines, -117 lines 0 comments Download
D ash/system/web_notification/web_notification_list.cc View 1 chunk +0 lines, -190 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 6 chunks +7 lines, -8 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 2 3 4 5 6 10 chunks +29 lines, -28 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
D ash/system/web_notification/web_notification_view.h View 1 chunk +0 lines, -81 lines 0 comments Download
D ash/system/web_notification/web_notification_view.cc View 1 chunk +0 lines, -322 lines 0 comments Download
M ash/wm/gestures/tray_gesture_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/balloon_collection_impl_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/balloon_view_ash.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/strings/ui_strings.grd View 1 2 3 4 5 6 1 chunk +18 lines, -0 lines 0 comments Download
A + ui/message_center/message_bubble_base.h View 2 chunks +19 lines, -22 lines 0 comments Download
A + ui/message_center/message_bubble_base.cc View 2 chunks +18 lines, -18 lines 0 comments Download
A + ui/message_center/message_center.h View 5 chunks +13 lines, -13 lines 0 comments Download
A + ui/message_center/message_center.cc View 5 chunks +8 lines, -7 lines 0 comments Download
A + ui/message_center/message_center.gyp View 1 2 1 chunk +16 lines, -18 lines 0 comments Download
A ui/message_center/message_center_bubble.h View 1 chunk +42 lines, -0 lines 0 comments Download
A + ui/message_center/message_center_bubble.cc View 9 chunks +27 lines, -29 lines 0 comments Download
A ui/message_center/message_center_export.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ui/message_center/message_popup_bubble.h View 1 chunk +50 lines, -0 lines 0 comments Download
A + ui/message_center/message_popup_bubble.cc View 6 chunks +29 lines, -30 lines 0 comments Download
A + ui/message_center/message_view.h View 3 chunks +14 lines, -15 lines 0 comments Download
A + ui/message_center/message_view.cc View 10 chunks +24 lines, -28 lines 0 comments Download
A + ui/message_center/notification_list.h View 4 chunks +28 lines, -13 lines 0 comments Download
A + ui/message_center/notification_list.cc View 11 chunks +40 lines, -35 lines 0 comments Download
M ui/resources/ui_resources.grd View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + ui/views/bubble/tray_bubble_view.h View 1 2 3 4 5 6 8 chunks +14 lines, -12 lines 0 comments Download
A + ui/views/bubble/tray_bubble_view.cc View 1 2 3 4 5 6 7 8 7 chunks +9 lines, -14 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
miket_OOO
lgtm
8 years, 2 months ago (2012-10-22 17:58:00 UTC) #1
stevenjb
ben - this has made it through the bots, can you take a look when ...
8 years, 2 months ago (2012-10-25 00:45:22 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 1 month ago (2012-10-25 18:24:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11229022/18059
8 years, 1 month ago (2012-10-25 18:29:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11229022/26001
8 years, 1 month ago (2012-10-27 12:22:16 UTC) #5
commit-bot: I haz the power
Failed to apply patch for ui/views/bubble/tray_bubble_view.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; A ui/views/bubble/tray_bubble_view.cc ...
8 years, 1 month ago (2012-10-27 12:22:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11229022/41001
8 years, 1 month ago (2012-10-30 00:53:35 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-10-30 05:12:14 UTC) #8
Change committed as 164857

Powered by Google App Engine
This is Rietveld 408576698