Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Issue 11228010: Do not wait for the double tap timeout on pages with fixed page scale (Closed)

Created:
8 years, 2 months ago by Yusuf
Modified:
8 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Do not wait for the double tap timeout on pages with fixed page scale We should't wait for the double tap timeout if we are on a web page that has a fixed page scale. This patch lets us register the single tap right away if that is the case. BUG=133391 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163445

Patch Set 1 #

Patch Set 2 : Fixed build error, Was calling a function on ContentViewCore #

Patch Set 3 : Added new method to mock child classes in test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 1 2 chunks +17 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yusuf
This carries over the fix on m18 with some modifications needed after the refactorings in ...
8 years, 2 months ago (2012-10-19 21:18:32 UTC) #1
Yaron
lgtm but please wait for aelias to confirm
8 years, 2 months ago (2012-10-22 18:04:52 UTC) #2
aelias_OOO_until_Jul13
lgtm
8 years, 2 months ago (2012-10-22 18:31:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11228010/1
8 years, 2 months ago (2012-10-22 19:37:44 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 2 months ago (2012-10-22 19:55:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11228010/9001
8 years, 2 months ago (2012-10-22 20:44:50 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 2 months ago (2012-10-22 21:20:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11228010/10002
8 years, 2 months ago (2012-10-22 21:25:24 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-22 23:52:13 UTC) #9
Change committed as 163445

Powered by Google App Engine
This is Rietveld 408576698