Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11228005: Fix mem leaks in DomStorageContextTest. (Closed)

Created:
8 years, 2 months ago by marja
Modified:
8 years, 2 months ago
CC:
chromium-reviews, glider+watch_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, michaeln
Visibility:
Public.

Description

Fix mem leaks in DomStorageContextTest. The leaks were introduced by r162886 and only occur in the test. BUG=156784 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163103

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/dom_storage/dom_storage_context_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
marja
ptal
8 years, 2 months ago (2012-10-19 16:41:43 UTC) #1
jochen (gone - plz use gerrit)
lgtm
8 years, 2 months ago (2012-10-19 16:45:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/11228005/1
8 years, 2 months ago (2012-10-19 16:46:13 UTC) #3
commit-bot: I haz the power
Failed to apply patch for tools/valgrind/memcheck/suppressions.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years, 2 months ago (2012-10-19 16:46:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/11228005/5001
8 years, 2 months ago (2012-10-19 17:02:08 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-19 17:26:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/11228005/5001
8 years, 2 months ago (2012-10-19 18:54:07 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-19 19:41:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/11228005/5001
8 years, 2 months ago (2012-10-19 21:57:18 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-10-20 00:20:28 UTC) #10 
Change committed as 163103

Powered by Google App Engine
This is Rietveld 408576698