Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 11227047: Compile webkit_compositor_bindings_unittests on Android. (Closed)

Created:
8 years, 2 months ago by shashi
Modified:
8 years, 1 month ago
CC:
chromium-reviews, ilevy+watch_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, bulach+watch_chromium.org, cc-bugs_chromium.org, peter+watch_chromium.org
Visibility:
Public.

Description

Compile webkit_compositor_bindings_unittests on Android. Compile webkit_compositor_bindings_unittests on Android and add them to android experimental step. BUG=152702 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164015

Patch Set 1 #

Total comments: 1

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M build/all_android.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/buildbot/buildbot_functions.sh View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings_tests.gyp View 2 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
shashi
enne: webkit/compositor_bindings/ nileshagrawal: all ilevy: build/android/buildbot/
8 years, 2 months ago (2012-10-23 17:48:46 UTC) #1
nilesh
LGTM with nit. https://chromiumcodereview.appspot.com/11227047/diff/1/build/all_android.gyp File build/all_android.gyp (right): https://chromiumcodereview.appspot.com/11227047/diff/1/build/all_android.gyp#newcode64 build/all_android.gyp:64: '../webkit/compositor_bindings/compositor_bindings_tests.gyp:webkit_compositor_bindings_unittests_apk' the unittest apk targets are ...
8 years, 2 months ago (2012-10-23 18:01:27 UTC) #2
Isaac (use chromium)
Please change description to be more clear. How about: s/enable/compile? Isaac On Oct 23, 2012, ...
8 years, 2 months ago (2012-10-23 18:10:37 UTC) #3
shashi
done. On 2012/10/23 18:10:37, Isaac (use chromium acct) wrote: > Please change description to be ...
8 years, 2 months ago (2012-10-23 18:12:52 UTC) #4
shashi
enne, nduca: Owners approval.
8 years, 1 month ago (2012-10-25 00:31:05 UTC) #5
jamesr
lgtm for webkit/
8 years, 1 month ago (2012-10-25 00:32:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11227047/8001
8 years, 1 month ago (2012-10-25 00:34:13 UTC) #7
shashi
On 2012/10/25 00:32:07, jamesr wrote: > lgtm for webkit/ Thanks :).
8 years, 1 month ago (2012-10-25 00:37:45 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 04:59:01 UTC) #9
Change committed as 164015

Powered by Google App Engine
This is Rietveld 408576698