Issue 11226002: Files app: fixed infinite Google Drive loading spinner

Issue 11226002: Files app: fixed infinite Google Drive loading spinner (Closed)

Created:
8 years, 2 months ago by Vladislav Kaznacheev

Modified:
8 years, 2 months ago

Reviewers:
SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Files app: fixed infinite Google Drive loading spinner BUG=156804 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163240

Patch Set 2 : Addressed comments #

Patch Set 3 : Rebase #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	chrome/browser/resources/file_manager/js/directory_model.js	View	1	4 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

I don't know how I missed a breakage I introduced in https://chromiumcodereview.appspot.com/11088074/. This fix looks ...

8 years, 2 months ago (2012-10-19 10:18:03 UTC) #1

SeRya

http://codereview.chromium.org/11226002/diff/1/chrome/browser/resources/file_manager/js/directory_model.js File chrome/browser/resources/file_manager/js/directory_model.js (left): http://codereview.chromium.org/11226002/diff/1/chrome/browser/resources/file_manager/js/directory_model.js#oldcode1108 chrome/browser/resources/file_manager/js/directory_model.js:1108: if (rootType != RootType.GDATA) The removed condition was essential. ...

8 years, 2 months ago (2012-10-19 11:00:25 UTC) #2

Vladislav Kaznacheev

PTAL https://chromiumcodereview.appspot.com/11226002/diff/1/chrome/browser/resources/file_manager/js/directory_model.js File chrome/browser/resources/file_manager/js/directory_model.js (left): https://chromiumcodereview.appspot.com/11226002/diff/1/chrome/browser/resources/file_manager/js/directory_model.js#oldcode1108 chrome/browser/resources/file_manager/js/directory_model.js:1108: if (rootType != RootType.GDATA) On 2012/10/19 11:00:25, SeRya ...

8 years, 2 months ago (2012-10-19 13:48:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/11226002/3001

8 years, 2 months ago (2012-10-19 17:16:27 UTC) #5

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...

8 years, 2 months ago (2012-10-19 17:53:42 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/11226002/13002

8 years, 2 months ago (2012-10-19 18:53:58 UTC) #7

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...

8 years, 2 months ago (2012-10-19 20:24:43 UTC) #8

kochi

8 years, 2 months ago (2012-10-22 04:51:52 UTC) #9

On 2012/10/19 20:24:43, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build.
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

Hey commit-bot,
when did you start compiling Javascipt? :)

Expand Messages | Collapse Messages