Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 11225030: Fix warnings about tautological compares by recent Clang versions. (Closed)

Created:
8 years, 2 months ago by hans
Modified:
8 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix warnings about tautological compares by recent Clang versions. This fixes the following Clang warnings: ../../v8/src/ia32/assembler-ia32.cc:1504:24: warning: comparison of constant 16 with expression of type 'v8::internal::Condition' is always true [-Wtautological-constant-out-of-range-compare] ASSERT(0 <= cc && cc < 16); ~~~~~~~~~~~~~~~~~~~~~^~~~~ ../../v8/src/ia32/assembler-ia32.cc:1536:27: warning: comparison of constant 16 with expression of type 'v8::internal::Condition' is always true [-Wtautological-constant-out-of-range-compare] ASSERT((0 <= cc) && (cc < 16)); ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ BUG=crbug.com/151927 Committed: https://code.google.com/p/v8/source/detail?r=12792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ia32/assembler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hans
Hi Ulan, I've got another fix for a Clang warning. Hopefully I managed to upload ...
8 years, 2 months ago (2012-10-22 15:42:16 UTC) #1
ulan
8 years, 2 months ago (2012-10-22 15:53:33 UTC) #2
LGTM, the upload is correct. I will land it for you.

Powered by Google App Engine
This is Rietveld 408576698