Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 11223002: Restore proper handling of a disabled 3g network on the settings page. (Closed)

Created:
8 years, 2 months ago by kevers
Modified:
8 years, 2 months ago
Reviewers:
csilv
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Restore proper handling of a disabled 3g network on the settings page. BUG=154963 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163304

Patch Set 1 #

Patch Set 2 : Revert patch for touch events. #

Patch Set 3 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M chrome/browser/resources/options/chromeos/network_list.js View 1 2 2 chunks +29 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kevers
Hi Chris, Can you please have a look at this CL.
8 years, 2 months ago (2012-10-18 19:40:59 UTC) #1
kevers
8 years, 2 months ago (2012-10-18 20:36:59 UTC) #2
csilv
lgtm
8 years, 2 months ago (2012-10-19 16:54:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/11223002/4001
8 years, 2 months ago (2012-10-19 17:54:34 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) compile
8 years, 2 months ago (2012-10-19 19:00:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/11223002/4001
8 years, 2 months ago (2012-10-19 19:13:52 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-19 20:11:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/11223002/4001
8 years, 2 months ago (2012-10-22 15:57:24 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-22 16:39:54 UTC) #9
Change committed as 163304

Powered by Google App Engine
This is Rietveld 408576698