Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 11221003: Remove -debug suffix in apk names. (Closed)

Created:
8 years, 2 months ago by shashi
Modified:
8 years, 2 months ago
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Remove -debug suffix in apk names. -debug suffix is used even for Release builds, remove this suffix now apk name will have no suffix in either Debug or Release builds. BUG=155946 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M build/android/ant/chromium-apk.xml View 1 chunk +1 line, -1 line 0 comments Download
M build/android/ant/create-test-jar.js View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/ant/sdk-targets.xml View 3 chunks +3 lines, -7 lines 0 comments Download
M build/android/buildbot/buildbot_functions.sh View 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/test_options_parser.py View 1 chunk +2 lines, -3 lines 0 comments Download
M build/java_apk.gypi View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
shashi
8 years, 2 months ago (2012-10-18 18:53:25 UTC) #1
Peter Beverloo
Is there a safe/graceful migration path possible here? WebKit scripts also rely on the -debug ...
8 years, 2 months ago (2012-10-18 19:13:29 UTC) #2
frankf
lgtm
8 years, 2 months ago (2012-10-18 19:17:34 UTC) #3
Isaac (away)
buildbot lgtm
8 years, 2 months ago (2012-10-18 19:24:30 UTC) #4
Yaron
On 2012/10/18 19:24:30, Isaac wrote: > buildbot lgtm lgtm but be sure to test clobber ...
8 years, 2 months ago (2012-10-18 19:27:15 UTC) #5
shashi
WebKit should be unaffected, for two reasons: 1.WebKit tests use native_test_apk.xml instead of our ant ...
8 years, 2 months ago (2012-10-18 19:27:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11221003/1
8 years, 2 months ago (2012-10-18 20:06:28 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-18 21:52:18 UTC) #8
Change committed as 162803

Powered by Google App Engine
This is Rietveld 408576698