Chromium Code Reviews
Help | Chromium Project | Sign in
(506)

Issue 11205004: Fix bug 145175: [Win] Frameless app windows are not resizable if no draggable region is specified (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by jianli
Modified:
1 year, 5 months ago
CC:
chromium-reviews_chromium.org, jeremya+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Fix bug 145175: [Win] Frameless app windows are not resizable if no draggable region is specified

This happens because RWHV is created for the new RVH instead of the existing RVH associated with the web contents when navigating a web contents to extension URL (see http://crbug.com/123007). When ShellWindowViews tries to set the clickthrough region for resizing purpose, it fails due to no RWHV for the existing RVH. The fix is to make the native window do it again when RWHV is available after RVH is updated.

BUG=145175
TEST=Manual test by launching and resizing frameless window without draggable region specified


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163698

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make new method pure virtual #

Total comments: 1

Patch Set 3 : Patch to land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Lint Patch
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h View 1 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/browser/ui/extensions/native_shell_window.h View 1 2 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/extensions/shell_window.cc View 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/gtk/extensions/shell_window_gtk.h View 1 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/browser/ui/views/extensions/shell_window_views.h View 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/browser/ui/views/extensions/shell_window_views.cc View 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 10
jianli
1 year, 6 months ago #1
jeremya
lgtm
1 year, 6 months ago #2
jeremya
http://codereview.chromium.org/11205004/diff/1/chrome/browser/ui/extensions/native_shell_window.h File chrome/browser/ui/extensions/native_shell_window.h (right): http://codereview.chromium.org/11205004/diff/1/chrome/browser/ui/extensions/native_shell_window.h#newcode41 chrome/browser/ui/extensions/native_shell_window.h:41: virtual void RenderViewHostChanged() {} It might be better to ...
1 year, 6 months ago #3
jianli
On Wed, Oct 17, 2012 at 3:57 PM, <jeremya@chromium.org> wrote: > > http://codereview.chromium.**org/11205004/diff/1/chrome/** > browser/ui/extensions/native_**shell_window.h<http://codereview.chromium.org/11205004/diff/1/chrome/browser/ui/extensions/native_shell_window.h> ...
1 year, 6 months ago #4
jeremya
Yeah, it's a bit of a pain to add all the implementations of it everywhere. ...
1 year, 6 months ago #5
jianli
New patch uploaded to make it pure virtual. On Wed, Oct 17, 2012 at 4:13 ...
1 year, 6 months ago #6
jianli
Ben, could you please review the patch? Thanks.
1 year, 5 months ago #7
Ben Goodger (Google)
lgtm http://codereview.chromium.org/11205004/diff/10003/chrome/browser/ui/extensions/native_shell_window.h File chrome/browser/ui/extensions/native_shell_window.h (right): http://codereview.chromium.org/11205004/diff/10003/chrome/browser/ui/extensions/native_shell_window.h#newcode38 chrome/browser/ui/extensions/native_shell_window.h:38: // Called when the RenderViewHost is changed. this ...
1 year, 5 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/11205004/27001
1 year, 5 months ago #9
I haz the power (commit-bot)
1 year, 5 months ago #10
Change committed as 163698
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434