Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 112003005: Initialize Date parse cache with SMI instead of double to workaround sharing mutable heap numbers i… (Closed)

Created:
7 years ago by ulan
Modified:
7 years ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Initialize Date parse cache with SMI instead of double to workaround sharing mutable heap numbers in snapshot. This is the only field in the snapshot that was tracked as double. R=verwaest@chromium.org TEST=mjsunit/regress/regress-280531.js BUG=280531 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=18298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M src/date.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-280531.js View 1 chunk +5 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
Please take a look. This is the workaround we discussed. It is small and should ...
7 years ago (2013-12-11 12:47:51 UTC) #1
Toon Verwaest
lgtm
7 years ago (2013-12-11 13:06:58 UTC) #2
ulan
7 years ago (2013-12-11 13:11:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18298.

Powered by Google App Engine
This is Rietveld 408576698