Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 11200002: update_nacl_manifest improvements (Closed)

Created:
8 years, 2 months ago by Sam Clegg
Modified:
8 years, 2 months ago
Reviewers:
noelallen1, binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

update_nacl_manifest improvements. Add ability to leave size and checksum blank in the manifest and have it be filled in based by downloading the current files. Add -v/--verbose option which prints more information. Add -d/--debug option which will show backtraces for Errors() which is not normally useful. When in --dryrun mode write the generated file locally along with the current online one and show a diff of the two. BUG=155906 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162445

Patch Set 1 : #

Total comments: 5

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -56 lines) Patch
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 1 chunk +2 lines, -6 lines 0 comments Download
M native_client_sdk/src/build_tools/manifest_util.py View 1 12 chunks +39 lines, -15 lines 0 comments Download
M native_client_sdk/src/build_tools/nacl-mono-buildbot.py View 4 chunks +5 lines, -5 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/test_update_nacl_manifest.py View 1 3 chunks +32 lines, -5 lines 0 comments Download
M native_client_sdk/src/build_tools/update_nacl_manifest.py View 1 8 chunks +56 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam Clegg
8 years, 2 months ago (2012-10-16 22:13:08 UTC) #1
binji
lgtm http://codereview.chromium.org/11200002/diff/7001/native_client_sdk/src/build_tools/manifest_util.py File native_client_sdk/src/build_tools/manifest_util.py (right): http://codereview.chromium.org/11200002/diff/7001/native_client_sdk/src/build_tools/manifest_util.py#newcode155 native_client_sdk/src/build_tools/manifest_util.py:155: This allows the template mandifest to be maintained ...
8 years, 2 months ago (2012-10-16 23:09:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11200002/8006
8 years, 2 months ago (2012-10-16 23:19:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11200002/8006
8 years, 2 months ago (2012-10-17 11:21:48 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, content_browsertests, content_unittests, crypto_unittests, gpu_unittests, ...
8 years, 2 months ago (2012-10-17 11:40:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11200002/8006
8 years, 2 months ago (2012-10-17 16:29:38 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 17:42:04 UTC) #7
Change committed as 162445

Powered by Google App Engine
This is Rietveld 408576698