Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5164)

Unified Diff: chrome/browser/extensions/convert_web_app_unittest.cc

Issue 11198067: Move extension unpack intermediate dir to Extensions/Temp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: standardize names Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/convert_web_app.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/convert_web_app_unittest.cc
diff --git a/chrome/browser/extensions/convert_web_app_unittest.cc b/chrome/browser/extensions/convert_web_app_unittest.cc
index dc8c11285ed59f3b8f56272be3f4380e72eb17d1..22e1f43b1bf8d5d462a715a07d922629a58d561d 100644
--- a/chrome/browser/extensions/convert_web_app_unittest.cc
+++ b/chrome/browser/extensions/convert_web_app_unittest.cc
@@ -93,6 +93,9 @@ TEST(ExtensionFromWebApp, GenerateVersion) {
}
TEST(ExtensionFromWebApp, Basic) {
+ ScopedTempDir extensions_dir;
+ ASSERT_TRUE(extensions_dir.CreateUniqueTempDir());
+
WebApplicationInfo web_app;
web_app.manifest_url = GURL("http://aaronboodman.com/gearpad/manifest.json");
web_app.title = ASCIIToUTF16("Gearpad");
@@ -109,7 +112,8 @@ TEST(ExtensionFromWebApp, Basic) {
}
scoped_refptr<Extension> extension = ConvertWebAppToExtension(
- web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0));
+ web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0),
+ extensions_dir.path());
ASSERT_TRUE(extension.get());
ScopedTempDir extension_dir;
@@ -146,13 +150,17 @@ TEST(ExtensionFromWebApp, Basic) {
}
TEST(ExtensionFromWebApp, Minimal) {
+ ScopedTempDir extensions_dir;
+ ASSERT_TRUE(extensions_dir.CreateUniqueTempDir());
+
WebApplicationInfo web_app;
web_app.manifest_url = GURL("http://aaronboodman.com/gearpad/manifest.json");
web_app.title = ASCIIToUTF16("Gearpad");
web_app.app_url = GURL("http://aaronboodman.com/gearpad/");
scoped_refptr<Extension> extension = ConvertWebAppToExtension(
- web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0));
+ web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0),
+ extensions_dir.path());
ASSERT_TRUE(extension.get());
ScopedTempDir extension_dir;
« no previous file with comments | « chrome/browser/extensions/convert_web_app.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698