Move extension unpack intermediate dir to Extensions/Temp

chrome/common/extensions/extension_file_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_FILE_UTIL_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_FILE_UTIL_H_
 
 #include <string>
 #include <map>
 
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/message_bundle.h"
 
 class FilePath;
 class GURL;
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace extensions {
 class MessageBundle;
 }
 
 // Utilities for manipulating the on-disk storage of extensions.
 namespace extension_file_util {
 
-// The name of the directory inside the profile that we store installed
-// extension in.
-extern const char kInstallDirectoryName[];
-
 // Copies |unpacked_source_dir| into the right location under |extensions_dir|.
 // The destination directory is returned on success, or empty path is returned
 // on failure.
 FilePath InstallExtension(const FilePath& unpacked_source_dir,
                           const std::string& id,
                           const std::string& version,
                           const FilePath& extensions_dir);
 
 // Removes all versions of the extension with |id| from |extensions_dir|.
 void UninstallExtension(const FilePath& extensions_dir,
@@ skipping 70 matching lines @@
 bool CheckForIllegalFilenames(const FilePath& extension_path,
                               std::string* error);
 
 // Get a relative file path from a chrome-extension:// URL.
 FilePath ExtensionURLToRelativeFilePath(const GURL& url);
 
 // Get a full file path from a chrome-extension-resource:// URL, If the URL
 // points a file outside of root, this function will return empty FilePath.
 FilePath ExtensionResourceURLToFilePath(const GURL& url, const FilePath& root);
 
-// Get a path to a temp directory for unpacking an extension.
-// This is essentially PathService::Get(chrome::DIR_USER_DATA_TEMP, ...),
-// with a histogram that allows us to understand why it is failing.
-// Return an empty file path on failure.
-FilePath GetUserDataTempDir();
+// Returns a path to a temporary directory for unpacking an extension that will
+// be installed into |extensions_dir|. Creates the directory if necessary.
+// The directory will be on the same file system as |extensions_dir| so
+// that the extension directory can be efficiently renamed into place. Returns
+// an empty file path on failure.
+FilePath GetInstallTempDir(const FilePath& extensions_dir);
 
 // Helper function to delete files. This is used to avoid ugly casts which
 // would be necessary with PostMessage since file_util::Delete is overloaded.
 // TODO(skerner): Make a version of Delete that is not overloaded in file_util.
 void DeleteFile(const FilePath& path, bool recursive);
 
 }  // namespace extension_file_util
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_FILE_UTIL_H_