chrome/browser/autofill/select_control_handler.cc - Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/select_control_handler.cc

Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update AutofillFieldTest expectations Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autofill/select_control_handler.cc

diff --git a/chrome/browser/autofill/select_control_handler.cc b/chrome/browser/autofill/select_control_handler.cc

index d602911239440bd9e10bb076d33ef6730e790bdf..7006e477997715a4bdb9f1170be2a110d753794a 100644

--- a/chrome/browser/autofill/select_control_handler.cc

+++ b/chrome/browser/autofill/select_control_handler.cc

@@ -202,7 +202,7 @@ void FillSelectControl(const FormGroup& form_group,

AutofillFieldType type,

FormFieldData* field) {

DCHECK(field);

- DCHECK_EQ(ASCIIToUTF16("select-one"), field->form_control_type);

+ DCHECK_EQ("select-one", field->form_control_type);

DCHECK_EQ(field->option_values.size(), field->option_contents.size());

string16 field_text = form_group.GetCanonicalizedInfo(type);

« no previous file with comments | « chrome/browser/autofill/phone_field_unittest.cc ('k') | chrome/browser/autofill/select_control_handler_unittest.cc » ('j') | no next file with comments »