Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: chrome/browser/autofill/autofill_field_unittest.cc

Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update AutofillFieldTest expectations Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_field.cc ('k') | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_field_unittest.cc
diff --git a/chrome/browser/autofill/autofill_field_unittest.cc b/chrome/browser/autofill/autofill_field_unittest.cc
index 697e86c60951ee85b7bc214fa069ba76781ec4c5..e207b6b110383cec85a88978bff339b721e7a719 100644
--- a/chrome/browser/autofill/autofill_field_unittest.cc
+++ b/chrome/browser/autofill/autofill_field_unittest.cc
@@ -46,7 +46,7 @@ TEST(AutofillFieldTest, IsEmpty) {
TEST(AutofillFieldTest, FieldSignature) {
AutofillField field;
ASSERT_EQ(string16(), field.name);
- ASSERT_EQ(string16(), field.form_control_type);
+ ASSERT_EQ(std::string(), field.form_control_type);
// Signature is empty.
EXPECT_EQ("2085434232", field.FieldSignature());
@@ -56,16 +56,16 @@ TEST(AutofillFieldTest, FieldSignature) {
EXPECT_EQ("1606968241", field.FieldSignature());
// Field form control type is set.
- field.form_control_type = ASCIIToUTF16("Text");
- EXPECT_EQ("4246049809", field.FieldSignature());
+ field.form_control_type = "text";
+ EXPECT_EQ("502192749", field.FieldSignature());
// Heuristic type does not affect FieldSignature.
field.set_heuristic_type(NAME_FIRST);
- EXPECT_EQ("4246049809", field.FieldSignature());
+ EXPECT_EQ("502192749", field.FieldSignature());
// Server type does not affect FieldSignature.
field.set_server_type(NAME_LAST);
- EXPECT_EQ("4246049809", field.FieldSignature());
+ EXPECT_EQ("502192749", field.FieldSignature());
}
TEST(AutofillFieldTest, IsFieldFillable) {
« no previous file with comments | « chrome/browser/autofill/autofill_field.cc ('k') | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698