chrome/common/form_field_data.h - Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/form_field_data.h

Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes to default section handling Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/form_structure.cc ('K') | « chrome/common/autofill_messages.h ('k') | chrome/common/form_field_data.cc » ('j') | chrome/test/data/autofill/heuristics/input/01_autocomplete_attribute_advanced.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/form_field_data.h

diff --git a/chrome/common/form_field_data.h b/chrome/common/form_field_data.h

index 286fb727293e41e575650e8d2a9cadadaccf331a..de9375f6d4152c2a421b8865f5fa3bcdbc88df00 100644

--- a/chrome/common/form_field_data.h

+++ b/chrome/common/form_field_data.h

@@ -26,8 +26,8 @@ struct FormFieldData {

string16 label;

string16 name;

string16 value;

- string16 form_control_type;

- string16 autocomplete_type;

+ std::string form_control_type;

+ std::string autocomplete_attribute;

size_t max_length;

bool is_autofilled;

bool is_focusable;

@@ -50,7 +50,7 @@ std::ostream& operator<<(std::ostream& os, const FormFieldData& field);

EXPECT_EQ(expected.name, actual.name); \

EXPECT_EQ(expected.value, actual.value); \

EXPECT_EQ(expected.form_control_type, actual.form_control_type); \

- EXPECT_EQ(expected.autocomplete_type, actual.autocomplete_type); \

+ EXPECT_EQ(expected.autocomplete_attribute, actual.autocomplete_attribute); \

EXPECT_EQ(expected.max_length, actual.max_length); \

EXPECT_EQ(expected.is_autofilled, actual.is_autofilled); \

} while (0)