chrome/browser/autofill/autofill_field_unittest.cc - Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_field_unittest.cc

Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes to default section handling Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autofill/autofill_field_unittest.cc

diff --git a/chrome/browser/autofill/autofill_field_unittest.cc b/chrome/browser/autofill/autofill_field_unittest.cc

index 697e86c60951ee85b7bc214fa069ba76781ec4c5..b8afa86873bbcd7e44cf3e2a37e77b428ef4ad54 100644

--- a/chrome/browser/autofill/autofill_field_unittest.cc

+++ b/chrome/browser/autofill/autofill_field_unittest.cc

@@ -46,7 +46,7 @@ TEST(AutofillFieldTest, IsEmpty) {

TEST(AutofillFieldTest, FieldSignature) {

AutofillField field;

ASSERT_EQ(string16(), field.name);

- ASSERT_EQ(string16(), field.form_control_type);

+ ASSERT_EQ(std::string(), field.form_control_type);

// Signature is empty.

EXPECT_EQ("2085434232", field.FieldSignature());

@@ -56,7 +56,7 @@ TEST(AutofillFieldTest, FieldSignature) {

EXPECT_EQ("1606968241", field.FieldSignature());

// Field form control type is set.

- field.form_control_type = ASCIIToUTF16("Text");

+ field.form_control_type = "text";

EXPECT_EQ("4246049809", field.FieldSignature());

// Heuristic type does not affect FieldSignature.

« no previous file with comments | « chrome/browser/autofill/autofill_field.cc ('k') | chrome/browser/autofill/autofill_manager.cc » ('j') | chrome/browser/autofill/form_structure.cc » ('J')