chrome/browser/autofill/autocomplete_history_manager_unittest.cc - Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autocomplete_history_manager_unittest.cc

Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes to default section handling Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/autocomplete_history_manager.cc ('k') | chrome/browser/autofill/autofill_common_test.cc » ('j') | chrome/browser/autofill/form_structure.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autocomplete_history_manager_unittest.cc

diff --git a/chrome/browser/autofill/autocomplete_history_manager_unittest.cc b/chrome/browser/autofill/autocomplete_history_manager_unittest.cc

index 32823adfe3230aa7d6ecff59bbc6ff3bfd7d062d..e8b05c8c2f43e9e03a79b9d316560f37db511a63 100644

--- a/chrome/browser/autofill/autocomplete_history_manager_unittest.cc

+++ b/chrome/browser/autofill/autocomplete_history_manager_unittest.cc

@@ -74,7 +74,7 @@ TEST_F(AutocompleteHistoryManagerTest, CreditCardNumberValue) {

valid_cc.label = ASCIIToUTF16("Credit Card");

valid_cc.name = ASCIIToUTF16("ccnum");

valid_cc.value = ASCIIToUTF16("4012888888881881");

- valid_cc.form_control_type = ASCIIToUTF16("text");

+ valid_cc.form_control_type = "text";

form.fields.push_back(valid_cc);

EXPECT_CALL(*web_data_service_, AddFormFields(_)).Times(0);

@@ -97,7 +97,7 @@ TEST_F(AutocompleteHistoryManagerTest, NonCreditCardNumberValue) {

invalid_cc.label = ASCIIToUTF16("Credit Card");

invalid_cc.name = ASCIIToUTF16("ccnum");

invalid_cc.value = ASCIIToUTF16("4580123456789012");

- invalid_cc.form_control_type = ASCIIToUTF16("text");

+ invalid_cc.form_control_type = "text";

form.fields.push_back(invalid_cc);

EXPECT_CALL(*(web_data_service_.get()), AddFormFields(_)).Times(1);

@@ -117,7 +117,7 @@ TEST_F(AutocompleteHistoryManagerTest, SSNValue) {

ssn.label = ASCIIToUTF16("Social Security Number");

ssn.name = ASCIIToUTF16("ssn");

ssn.value = ASCIIToUTF16("078-05-1120");

- ssn.form_control_type = ASCIIToUTF16("text");

+ ssn.form_control_type = "text";

form.fields.push_back(ssn);

EXPECT_CALL(*web_data_service_, AddFormFields(_)).Times(0);

@@ -138,7 +138,7 @@ TEST_F(AutocompleteHistoryManagerTest, SearchField) {

search_field.label = ASCIIToUTF16("Search");

search_field.name = ASCIIToUTF16("search");

search_field.value = ASCIIToUTF16("my favorite query");

- search_field.form_control_type = ASCIIToUTF16("search");

+ search_field.form_control_type = "search";

form.fields.push_back(search_field);

EXPECT_CALL(*(web_data_service_.get()), AddFormFields(_)).Times(1);