[Autofill] Update the autocomplete types implementation to match the current HTML spec.

chrome/renderer/autofill/form_autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/string16.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
@@ skipping 146 matching lines @@
 
   WebElement web_element = frame->document().getElementById("element");
   WebFormControlElement element = web_element.to<WebFormControlElement>();
   FormFieldData result;
   WebFormControlElementToFormField(element, autofill::EXTRACT_VALUE, &result);
 
   FormFieldData expected;
   expected.name = ASCIIToUTF16("element");
   expected.value = ASCIIToUTF16("value");
   expected.form_control_type = ASCIIToUTF16("text");
+  expected.autocomplete_attribute = ASCIIToUTF16("off");
   expected.max_length = WebInputElement::defaultMaxLength();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, result);
 }
 
 // We should be able to extract a text field with maxlength specified.
 TEST_F(FormAutofillTest, WebFormControlElementToFormFieldMaxLength) {
   LoadHTML("<INPUT type=\"text\" id=\"element\" value=\"value\""
            "       maxlength=\"5\"/>");
 
   WebFrame* frame = GetMainFrame();
@@ skipping 132 matching lines @@
   WebFormControlElementToFormField(element, autofill::EXTRACT_VALUE, &result);
   expected.name = ASCIIToUTF16("submit");
   expected.form_control_type = ASCIIToUTF16("submit");
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, result);
 }
 
 // We should be able to extract the autocompletetype attribute.
 TEST_F(FormAutofillTest, WebFormControlElementToFormFieldAutocompletetype) {
   std::string html =
       "<INPUT type=\"text\" id=\"absent\"/>"
-      "<INPUT type=\"text\" id=\"empty\" x-autocompletetype=\"\"/>"
-      "<INPUT type=\"text\" id=\"whitespace\" x-autocompletetype=\"  \"/>"
-      "<INPUT type=\"text\" id=\"regular\" x-autocompletetype=\"email\"/>"
+      "<INPUT type=\"text\" id=\"empty\" autocomplete=\"\"/>"
+      "<INPUT type=\"text\" id=\"off\" autocomplete=\"off\"/>"
+      "<INPUT type=\"text\" id=\"regular\" autocomplete=\"email\"/>"
       "<INPUT type=\"text\" id=\"multi-valued\" "
-      "       x-autocompletetype=\"x-confirm-email email\"/>"
-      "<INPUT type=\"text\" id=\"unprefixed\" autocompletetype=\"email\"/>"
-      "<SELECT id=\"select\" x-autocompletetype=\"state\"/>"
+      "       autocomplete=\"billing email\"/>"
+      "<INPUT type=\"text\" id=\"experimental\" x-autocompletetype=\"email\"/>"
+      "<SELECT id=\"select\" autocomplete=\"state\"/>"
       "  <OPTION value=\"CA\">California</OPTION>"
       "  <OPTION value=\"TX\">Texas</OPTION>"
       "</SELECT>";
   html +=
-      "<INPUT type=\"text\" id=\"malicious\" x-autocompletetype=\"" +
+      "<INPUT type=\"text\" id=\"malicious\" autocomplete=\"" +
       std::string(10000, 'x') + "\"/>";
   LoadHTML(html.c_str());
 
   WebFrame* frame = GetMainFrame();
   ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
 
-  // An absent attribute is equivalent to an empty one.
-  WebElement web_element = frame->document().getElementById("absent");
-  WebFormControlElement element = web_element.to<WebFormControlElement>();
-  FormFieldData result1;
-  WebFormControlElementToFormField(element, autofill::EXTRACT_NONE, &result1);
+  struct TestCase {
+    const std::string element_id;
+    const std::string form_control_type;
+    const std::string autocomplete_attribute;
+  };
+  TestCase test_cases[] = {
+    // An absent attribute is equivalent to an empty one.
+    { "absent", "text", "" },
+    // Make sure there are no issues parsing an empty attribute.
+    { "empty", "text", "" },
+    // Make sure there are no issues parsing an attribute value that isn't a
+    // type hint.
+    { "off", "text", "off" },
+    // Common case: exactly one type specified.
+    { "regular", "text", "email" },
+    // Verify that we correctly extract multiple tokens as well.
+    { "multi-valued", "text", "billing email" },
+    // We previously extracted this data from the experimental
+    // 'x-autocompletetype' attribute.  Now that the field type hints are part
+    // of the spec under the autocomplete attribute, we no longer support the
+    // experimental version.
+    { "experimental", "text", "" },
+    // <select> elements should behave no differently from text fields here.
+    { "select", "select-one", "state" },
+    // Very long attribute values should be replaced by a default string, to
+    // prevent malicious websites from DOSing the browser process.
+    { "malicious", "text", "x-max-data-length-exceeded" },
+  };

[Dan Beam, 2012/10/19 04:25:41]

this looks way better!

 
-  FormFieldData expected;
-  expected.name = ASCIIToUTF16("absent");
-  expected.form_control_type = ASCIIToUTF16("text");
-  expected.autocomplete_type = string16();
-  expected.max_length = WebInputElement::defaultMaxLength();
-  EXPECT_FORM_FIELD_DATA_EQUALS(expected, result1);
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
+    WebElement web_element = frame->document().getElementById(
+        ASCIIToUTF16(test_cases[i].element_id));
+    WebFormControlElement element = web_element.to<WebFormControlElement>();
+    FormFieldData result;
+    WebFormControlElementToFormField(element, autofill::EXTRACT_NONE, &result);
 
-  web_element = frame->document().getElementById("empty");
-  element = web_element.to<WebFormControlElement>();
-  FormFieldData result2;
-  WebFormControlElementToFormField(element, autofill::EXTRACT_NONE, &result2);
-  expected.name = ASCIIToUTF16("empty");
-  expected.form_control_type = ASCIIToUTF16("text");
-  expected.autocomplete_type = string16();
-  expected.max_length = WebInputElement::defaultMaxLength();
-  EXPECT_FORM_FIELD_DATA_EQUALS(expected, result2);
+    FormFieldData expected;
+    expected.name = ASCIIToUTF16(test_cases[i].element_id);
+    expected.form_control_type = ASCIIToUTF16(test_cases[i].form_control_type);
+    expected.autocomplete_attribute =
+        ASCIIToUTF16(test_cases[i].autocomplete_attribute);
+    if (test_cases[i].form_control_type == "text")
+      expected.max_length = WebInputElement::defaultMaxLength();

[Dan Beam, 2012/10/19 04:25:41]

nit: ternary IMO, if it doesn't look gross

[Ilya Sherman, 2012/10/19 04:54:11]

Using a ternary operator results in wrapped lines anyway, so I prefer the
if/else.

+    else
+      expected.max_length = 0;
 
-  // The renderer should trim whitespace.
-  web_element = frame->document().getElementById("whitespace");
-  element = web_element.to<WebFormControlElement>();
-  FormFieldData result3;
-  WebFormControlElementToFormField(element, autofill::EXTRACT_NONE, &result3);
-  expected.name = ASCIIToUTF16("whitespace");
-  expected.form_control_type = ASCIIToUTF16("text");
-  expected.autocomplete_type = string16();
-  expected.max_length = WebInputElement::defaultMaxLength();
-  EXPECT_FORM_FIELD_DATA_EQUALS(expected, result3);
-
-  // Common case: exactly one type specified.
-  web_element = frame->document().getElementById("regular");
-  element = web_element.to<WebFormControlElement>();
-  FormFieldData result4;
-  WebFormControlElementToFormField(element, autofill::EXTRACT_NONE, &result4);
-  expected.name = ASCIIToUTF16("regular");
-  expected.form_control_type = ASCIIToUTF16("text");
-  expected.autocomplete_type = ASCIIToUTF16("email");
-  expected.max_length = WebInputElement::defaultMaxLength();
-  EXPECT_FORM_FIELD_DATA_EQUALS(expected, result4);
-
-  // Verify that we correctly extract fallback types as well.
-  web_element = frame->document().getElementById("multi-valued");
-  element = web_element.to<WebFormControlElement>();
-  FormFieldData result5;
-  WebFormControlElementToFormField(element, autofill::EXTRACT_NONE, &result5);
-  expected.name = ASCIIToUTF16("multi-valued");
-  expected.form_control_type = ASCIIToUTF16("text");
-  expected.autocomplete_type = ASCIIToUTF16("x-confirm-email email");
-  expected.max_length = WebInputElement::defaultMaxLength();
-  EXPECT_FORM_FIELD_DATA_EQUALS(expected, result5);
-
-  // The attribute is not yet part of the HTML standard, so we only recognize
-  // the prefixed version -- 'x-autocompletetype' -- and not the unprefixed one.
-  web_element = frame->document().getElementById("unprefixed");
-  element = web_element.to<WebFormControlElement>();
-  FormFieldData result6;
-  WebFormControlElementToFormField(element, autofill::EXTRACT_NONE, &result6);
-  expected.name = ASCIIToUTF16("unprefixed");
-  expected.form_control_type = ASCIIToUTF16("text");
-  expected.autocomplete_type = string16();
-  expected.max_length = WebInputElement::defaultMaxLength();
-  EXPECT_FORM_FIELD_DATA_EQUALS(expected, result6);
-
-  // <select> elements should behave no differently from text fields here.
-  web_element = frame->document().getElementById("select");
-  element = web_element.to<WebFormControlElement>();
-  FormFieldData result7;
-  WebFormControlElementToFormField(element, autofill::EXTRACT_NONE, &result7);
-  expected.name = ASCIIToUTF16("select");
-  expected.form_control_type = ASCIIToUTF16("select-one");
-  expected.autocomplete_type = ASCIIToUTF16("state");
-  expected.max_length = 0;
-  EXPECT_FORM_FIELD_DATA_EQUALS(expected, result7);
-
-  // Very long attribute values should be replaced by a default string, to
-  // prevent malicious websites from DOSing the browser process.
-  web_element = frame->document().getElementById("malicious");
-  element = web_element.to<WebFormControlElement>();
-  FormFieldData result8;
-  WebFormControlElementToFormField(element, autofill::EXTRACT_NONE, &result8);
-  expected.name = ASCIIToUTF16("malicious");
-  expected.form_control_type = ASCIIToUTF16("text");
-  expected.autocomplete_type = ASCIIToUTF16("x-max-data-length-exceeded");
-  expected.max_length = WebInputElement::defaultMaxLength();
-  EXPECT_FORM_FIELD_DATA_EQUALS(expected, result8);
+    SCOPED_TRACE(test_cases[i].element_id);
+    EXPECT_FORM_FIELD_DATA_EQUALS(expected, result);
+  }
 }
 
 TEST_F(FormAutofillTest, WebFormElementToFormData) {
   LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            " <LABEL for=\"firstname\">First name:</LABEL>"
            "  <INPUT type=\"text\" id=\"firstname\" value=\"John\"/>"
            " <LABEL for=\"lastname\">Last name:</LABEL>"
            "  <INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/>"
            " <LABEL for=\"state\">State:</LABEL>"
            "  <SELECT id=\"state\"/>"
@@ skipping 302 matching lines @@
   expected.value = ASCIIToUTF16("John");
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[0]);
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, field);
 
   expected.name = ASCIIToUTF16("lastname");
   expected.value = ASCIIToUTF16("Smith");
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("email");
   expected.value = ASCIIToUTF16("john@example.com");
+  expected.autocomplete_attribute = ASCIIToUTF16("off");
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 
   expected.name = ASCIIToUTF16("phone");
   expected.value = ASCIIToUTF16("1.800.555.1234");
+  expected.autocomplete_attribute = string16();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[3]);
 
   // Try again, but require autocomplete.
   FormData form2;
   FormFieldData field2;
   EXPECT_TRUE(FindFormAndFieldForInputElement(input_element, &form2, &field2,
                                               autofill::REQUIRE_AUTOCOMPLETE));
   EXPECT_EQ(ASCIIToUTF16("TestForm"), form2.name);
   EXPECT_EQ(GURL(web_frame->document().url()), form2.origin);
   EXPECT_EQ(GURL("http://buh.com"), form2.action);
@@ skipping 1726 matching lines @@
   expected.name = ASCIIToUTF16("firstname");
   expected.value = string16();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields2[0]);
 
   expected.name = ASCIIToUTF16("lastname");
   expected.value = string16();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields2[1]);
 
   expected.name = ASCIIToUTF16("noAC");
   expected.value = string16();
+  expected.autocomplete_attribute = ASCIIToUTF16("off");
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields2[2]);
 
   expected.name = ASCIIToUTF16("notenabled");
   expected.value = ASCIIToUTF16("no clear");
+  expected.autocomplete_attribute = string16();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields2[3]);
 
   // Verify that the cursor position has been updated.
   EXPECT_EQ(0, firstname.selectionStart());
   EXPECT_EQ(0, firstname.selectionEnd());
 }
 
 TEST_F(FormAutofillTest, ClearFormWithNodeContainingSelectOne) {
   LoadHTML(
       "<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
@@ skipping 418 matching lines @@
   expected.form_control_type = ASCIIToUTF16("text");
   expected.max_length = WebInputElement::defaultMaxLength();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("country");
   expected.value = ASCIIToUTF16("AL");
   expected.form_control_type = ASCIIToUTF16("select-one");
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 }