Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 11198029: Android: remove check for JNI method id. (Closed)

Created:
8 years, 2 months ago by bulach
Modified:
8 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, johnme
Visibility:
Public.

Description

Android: remove check for JNI method id. Following r162186, the JNI method ids are lazily initialized. Also, remove obsolete TODO, as the JNI is now initialized for unittests. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163117

Patch Set 1 #

Total comments: 2

Patch Set 2 : Joth's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M net/android/network_library.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
8 years, 2 months ago (2012-10-17 13:48:39 UTC) #1
bulach
8 years, 2 months ago (2012-10-17 13:49:10 UTC) #2
bulach
8 years, 2 months ago (2012-10-17 16:47:40 UTC) #3
joth
http://codereview.chromium.org/11198029/diff/1/net/android/network_library.cc File net/android/network_library.cc (right): http://codereview.chromium.org/11198029/diff/1/net/android/network_library.cc#newcode32 net/android/network_library.cc:32: } you can remove the entire if() block, as ...
8 years, 2 months ago (2012-10-17 20:46:19 UTC) #4
bulach
thanks joth! another look please? http://codereview.chromium.org/11198029/diff/1/net/android/network_library.cc File net/android/network_library.cc (right): http://codereview.chromium.org/11198029/diff/1/net/android/network_library.cc#newcode32 net/android/network_library.cc:32: } On 2012/10/17 20:46:19, ...
8 years, 2 months ago (2012-10-18 08:46:58 UTC) #5
Satish
lgtm
8 years, 2 months ago (2012-10-18 09:53:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11198029/7001
8 years, 2 months ago (2012-10-18 09:55:13 UTC) #7
joth
lgtm
8 years, 2 months ago (2012-10-18 17:00:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11198029/7001
8 years, 2 months ago (2012-10-20 01:15:56 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-10-20 01:16:08 UTC) #10
Change committed as 163117

Powered by Google App Engine
This is Rietveld 408576698