Allow building Official Chrome builds in Debug on ARM by avoiding overcommitting registers.

Allow building Official Chrome builds in Debug on ARM by avoiding overcommitting registers.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162414

[Ami GONE FROM CHROMIUM, 2012-10-17 07:59:22]

digit: please review
thestig: OWNERS please
ddorwin: FYI

[Lei Zhang, 2012-10-17 08:07:34]

Deferring to digit, because guess what, breakpad/OWNERS doesn't have "set
noparent". Looks ok to me though.

[digit1, 2012-10-17 08:23:59]

btw, Mark is the right person to ask for any Breakpad-related issues.

https://codereview.chromium.org/11198019/diff/3/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

https://codereview.chromium.org/11198019/diff/3/breakpad/breakpad.gyp#newcode536
breakpad/breakpad.gyp:536: # Avoid running out of registers.
Can you put that in a chromeos-specific condition, and explain the issue in more
details (e.g. "Avoid compile issues with the linux_syscall_support.h sys_clone()
inline assembly").

This would allow you to remove this more easily in the future when/if the
problem is fixed in a future version of LSS. (Yes, I really hate exotic compiler
flags that creep in build files without a good explanation :-))

[Ami GONE FROM CHROMIUM, 2012-10-17 08:48:32]

@mark: can i haz lgty?

@digit: thanks!

https://codereview.chromium.org/11198019/diff/3/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

https://codereview.chromium.org/11198019/diff/3/breakpad/breakpad.gyp#newcode536
breakpad/breakpad.gyp:536: # Avoid running out of registers.
On 2012/10/17 08:23:59, digit1 wrote:
> Can you put that in a chromeos-specific condition, and explain the issue in
more
> details (e.g. "Avoid compile issues with the linux_syscall_support.h
sys_clone()
> inline assembly").
> 
> This would allow you to remove this more easily in the future when/if the
> problem is fixed in a future version of LSS. (Yes, I really hate exotic
compiler
> flags that creep in build files without a good explanation :-))

Done.

[Mark Mentovai, 2012-10-17 14:07:06]

LGTM

[commit-bot: I haz the power, 2012-10-17 14:22:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/11198019/7001

[commit-bot: I haz the power, 2012-10-17 15:43:05]

Change committed as 162414