Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 11198017: Add DecryptingAudioDecoder. (Closed)

Created:
8 years, 2 months ago by xhwang
Modified:
8 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Add DecryptingAudioDecoder. BUG=123421 TEST=added new tests to media_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162976

Patch Set 1 #

Patch Set 2 : Updated the decoder. Need to update tests later. #

Patch Set 3 : Add unittests #

Total comments: 3

Patch Set 4 : ready for review, w/ questions about Stop() #

Patch Set 5 : rebase only #

Patch Set 6 : Stop() removed. #

Total comments: 2

Patch Set 7 : fix redefinition of ACTIONS in test, add DAD into pipeline. #

Patch Set 8 : rebase #

Total comments: 8

Patch Set 9 : Add TODO #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+655 lines, -132 lines) Patch
A + media/filters/decrypting_audio_decoder.h View 1 2 3 4 5 7 chunks +32 lines, -26 lines 0 comments Download
A + media/filters/decrypting_audio_decoder.cc View 1 2 3 4 5 6 7 8 9 12 chunks +89 lines, -105 lines 0 comments Download
A media/filters/decrypting_audio_decoder_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +507 lines, -0 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/media/filter_helpers.cc View 1 2 3 4 5 6 7 8 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
xhwang
This CL is ready for review. I left the Stop() for discussion even if AudioDecoder() ...
8 years, 2 months ago (2012-10-18 02:14:10 UTC) #1
scherkus (not reviewing)
On 2012/10/18 02:14:10, xhwang wrote: > http://codereview.chromium.org/11198017/diff/4/media/filters/decrypting_audio_decoder.h#newcode65 > media/filters/decrypting_audio_decoder.h:65: void Stop(const base::Closure& > closure); > ...
8 years, 2 months ago (2012-10-18 17:32:50 UTC) #2
xhwang
On 2012/10/18 17:32:50, scherkus wrote: > On 2012/10/18 02:14:10, xhwang wrote: > > > http://codereview.chromium.org/11198017/diff/4/media/filters/decrypting_audio_decoder.h#newcode65 ...
8 years, 2 months ago (2012-10-18 17:47:08 UTC) #3
scherkus (not reviewing)
On 2012/10/18 17:47:08, xhwang wrote: > On 2012/10/18 17:32:50, scherkus wrote: > > On 2012/10/18 ...
8 years, 2 months ago (2012-10-18 18:04:40 UTC) #4
xhwang
On 2012/10/18 18:04:40, scherkus wrote: > On 2012/10/18 17:47:08, xhwang wrote: > > On 2012/10/18 ...
8 years, 2 months ago (2012-10-18 18:48:45 UTC) #5
xhwang
Stop() removed. This CL is ready for review. PTAL!
8 years, 2 months ago (2012-10-18 21:07:04 UTC) #6
scherkus (not reviewing)
lgtm w/ q the amount of duplicated code is a bit of a downer (especially ...
8 years, 2 months ago (2012-10-18 21:13:12 UTC) #7
xhwang
Added the new DecryptingAudioDecoder into media pipeline and fixed ACTION redefinition in tests. PTAL again! ...
8 years, 2 months ago (2012-10-18 22:49:08 UTC) #8
scherkus (not reviewing)
http://codereview.chromium.org/11198017/diff/9009/media/filters/decrypting_audio_decoder.h File media/filters/decrypting_audio_decoder.h (right): http://codereview.chromium.org/11198017/diff/9009/media/filters/decrypting_audio_decoder.h#newcode157 media/filters/decrypting_audio_decoder.h:157: Decryptor::AudioBuffers queued_audio_frames_; sorry just for noticing this... why are ...
8 years, 2 months ago (2012-10-19 02:12:57 UTC) #9
xhwang
http://codereview.chromium.org/11198017/diff/9009/media/filters/decrypting_audio_decoder.h File media/filters/decrypting_audio_decoder.h (right): http://codereview.chromium.org/11198017/diff/9009/media/filters/decrypting_audio_decoder.h#newcode157 media/filters/decrypting_audio_decoder.h:157: Decryptor::AudioBuffers queued_audio_frames_; On 2012/10/19 02:12:58, scherkus wrote: > sorry ...
8 years, 2 months ago (2012-10-19 02:19:45 UTC) #10
scherkus (not reviewing)
http://codereview.chromium.org/11198017/diff/9009/webkit/media/filter_helpers.cc File webkit/media/filter_helpers.cc (right): http://codereview.chromium.org/11198017/diff/9009/webkit/media/filter_helpers.cc#newcode49 webkit/media/filter_helpers.cc:49: filter_collection->GetAudioDecoders()->push_back(decrypting_audio_decoder); On 2012/10/19 02:19:45, xhwang wrote: > On 2012/10/19 ...
8 years, 2 months ago (2012-10-19 02:23:05 UTC) #11
xhwang
http://codereview.chromium.org/11198017/diff/9009/webkit/media/filter_helpers.cc File webkit/media/filter_helpers.cc (right): http://codereview.chromium.org/11198017/diff/9009/webkit/media/filter_helpers.cc#newcode49 webkit/media/filter_helpers.cc:49: filter_collection->GetAudioDecoders()->push_back(decrypting_audio_decoder); On 2012/10/19 02:23:05, scherkus wrote: > On 2012/10/19 ...
8 years, 2 months ago (2012-10-19 02:40:34 UTC) #12
scherkus (not reviewing)
lgtm http://codereview.chromium.org/11198017/diff/9009/webkit/media/filter_helpers.cc File webkit/media/filter_helpers.cc (right): http://codereview.chromium.org/11198017/diff/9009/webkit/media/filter_helpers.cc#newcode49 webkit/media/filter_helpers.cc:49: filter_collection->GetAudioDecoders()->push_back(decrypting_audio_decoder); On 2012/10/19 02:40:35, xhwang wrote: > On ...
8 years, 2 months ago (2012-10-19 02:51:48 UTC) #13
xhwang
http://codereview.chromium.org/11198017/diff/9009/webkit/media/filter_helpers.cc File webkit/media/filter_helpers.cc (right): http://codereview.chromium.org/11198017/diff/9009/webkit/media/filter_helpers.cc#newcode49 webkit/media/filter_helpers.cc:49: filter_collection->GetAudioDecoders()->push_back(decrypting_audio_decoder); On 2012/10/19 02:51:48, scherkus wrote: > On 2012/10/19 ...
8 years, 2 months ago (2012-10-19 07:28:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/11198017/15
8 years, 2 months ago (2012-10-19 07:28:40 UTC) #15
commit-bot: I haz the power
Failed to apply patch for media/filters/decrypting_audio_decoder.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; A media/filters/decrypting_audio_decoder.cc ...
8 years, 2 months ago (2012-10-19 07:28:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/11198017/9012
8 years, 2 months ago (2012-10-19 08:12:48 UTC) #17
commit-bot: I haz the power
8 years, 2 months ago (2012-10-19 10:06:44 UTC) #18
Change committed as 162976

Powered by Google App Engine
This is Rietveld 408576698