Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 11196012: Compare the sizes of current & previous frames before each capture. (Closed)

Created:
8 years, 2 months ago by Wez
Modified:
8 years, 2 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Compare the sizes of current & previous frames before each capture. This ensures that the capturer will never try to preserve pixels from a preceding frame of a different size, in the case where the display has been resized but we have not yet received the resize notification. BUG=156201 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162484

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M remoting/host/video_frame_capturer_linux.cc View 8 chunks +26 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Wez
PTAL
8 years, 2 months ago (2012-10-17 00:08:36 UTC) #1
Jamie
lgtm
8 years, 2 months ago (2012-10-17 00:47:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/11196012/1
8 years, 2 months ago (2012-10-17 00:50:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/11196012/1
8 years, 2 months ago (2012-10-17 11:21:40 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 2 months ago (2012-10-17 11:24:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/11196012/14002
8 years, 2 months ago (2012-10-17 17:25:00 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 19:26:45 UTC) #7
Change committed as 162484

Powered by Google App Engine
This is Rietveld 408576698