Fix media galleries crash when the window is closed with config dialog open.

Fix media galleries crash when the window is closed with config dialog open.

BUG=156165
TEST=Open the media galleries config dialog with a test extension and close the window with the config dialog open.  The browser should not crash.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162402

[vandebo (ex-Chrome), 2012-10-16 22:14:57]

+asargent for OWNERS review.

[Lei Zhang, 2012-10-16 22:43:39]

lgtm

[commit-bot: I haz the power, 2012-10-16 23:00:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/11196007/1

[asargent_no_longer_on_chrome, 2012-10-16 23:01:46]

lgtm w/ one question

https://codereview.chromium.org/11196007/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

https://codereview.chromium.org/11196007/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:127: error_
= kInvalidRPH;
If the RPH no longer exists, doesn't that mean it's not around to get the error
message in its callback anyway? If so then it's probably fine to omit setting
the error_ member (but we should still call SendResponse, to free up any
resources in the API dispatching system).

[vandebo (ex-Chrome), 2012-10-16 23:17:28]

https://codereview.chromium.org/11196007/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

https://codereview.chromium.org/11196007/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:127: error_
= kInvalidRPH;
On 2012/10/16 23:01:47, Antony Sargent wrote:
> If the RPH no longer exists, doesn't that mean it's not around to get the
error
> message in its callback anyway? If so then it's probably fine to omit setting
> the error_ member (but we should still call SendResponse, to free up any
> resources in the API dispatching system).

Yea, I wasn't sure about that part.  Looking into it further,
UIThreadExtensionFunction::SendResponse doesn't call SendResponseImpl, which is
where error_ is consumed, so there's no need to set it.

Furthermore, that code assumes that if the rvh is valid, the rph will be valid
too, so I'm removing the rph check.

[commit-bot: I haz the power, 2012-10-16 23:18:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/11196007/4003

[commit-bot: I haz the power, 2012-10-17 11:20:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/11196007/4003

[commit-bot: I haz the power, 2012-10-17 11:27:19]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-17 11:57:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/11196007/4003

[commit-bot: I haz the power, 2012-10-17 14:25:22]

Change committed as 162402