Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 11196002: Fix ppapi TwoWayTest so that it constructs a unique IPC::ChannelHandle. (Closed)

Created:
8 years, 2 months ago by raymes
Modified:
8 years, 2 months ago
Reviewers:
yzshen1
CC:
chromium-reviews
Visibility:
Public.

Description

Fix ppapi TwoWayTest so that it constructs a unique IPC::ChannelHandle. When multiple TwoWayTests (run as ppapi_unittests) were run concurrently, several IPC ChannelHandles may have been created with the same name. This would cause the creation of the channel to fail (because the channel handle has to be unique). This was causing flaky tests on the trybots. This uses the process ID in the channel handle name so that they are guaranteed to be unique for the set of running processes. This also re-enables a test which I disabled under the suspiscion that it was related to this failure (but it isn't). BUG=155175 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M ppapi/proxy/plugin_var_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
raymes
8 years, 2 months ago (2012-10-16 17:40:50 UTC) #1
yzshen1
lgtm
8 years, 2 months ago (2012-10-16 23:46:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/11196002/1
8 years, 2 months ago (2012-10-17 16:06:30 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 17:59:16 UTC) #4
Change committed as 162458

Powered by Google App Engine
This is Rietveld 408576698