Upstream hooks for javascript touch handlers on Android.

Upstream hooks for javascript touch handlers on Android.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162763

[Yaron, 2012-10-17 23:55:42]

sadrul: content/browser/renderer_host
jam: non-android content
jcivelli: android files

[Yaron, 2012-10-17 23:55:42]

sadrul: content/browser/renderer_host
jam: non-android content
jcivelli: android files

[jam, 2012-10-18 01:18:23]

lgtm

[Jay Civelli, 2012-10-18 01:33:34]

lgtm

https://codereview.chromium.org/11195033/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/11195033/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_android.cc:489: 
Nit: remove blank line.

[sadrul, 2012-10-18 01:42:27]

LGTM with the note below:

http://codereview.chromium.org/11195033/diff/1/content/browser/renderer_host/...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

http://codereview.chromium.org/11195033/diff/1/content/browser/renderer_host/...
content/browser/renderer_host/render_widget_host_view_android.cc:383: void
RenderWidgetHostViewAndroid::ProcessTouchAck(bool processed) {
This has changed in trunk to ProcessAckedTouchEvent. Note that touch-events can
now be coalesced, and when that happens, the number of ACKs won't be the same as
the number of ForwardTouchEvent() calls made. I don't know what
ConfirmTouchEvent() does (or where it used to be called before this changed), so
this may not be an issue. But I wanted to point this out.

[Yaron, 2012-10-18 02:03:22]

http://codereview.chromium.org/11195033/diff/1/content/browser/renderer_host/...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

http://codereview.chromium.org/11195033/diff/1/content/browser/renderer_host/...
content/browser/renderer_host/render_widget_host_view_android.cc:383: void
RenderWidgetHostViewAndroid::ProcessTouchAck(bool processed) {
On 2012/10/18 01:42:27, sadrul wrote:
> This has changed in trunk to ProcessAckedTouchEvent. Note that touch-events
can
> now be coalesced, and when that happens, the number of ACKs won't be the same
as
> the number of ForwardTouchEvent() calls made. I don't know what
> ConfirmTouchEvent() does (or where it used to be called before this changed),
so
> this may not be an issue. But I wanted to point this out.

Ya, Android might still need to be further updated after your changes. It's
passed into our GestureHandler which I believe does some of the same work so we
can probably re-use more of your changes.

[commit-bot: I haz the power, 2012-10-18 17:53:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11195033/6002

[commit-bot: I haz the power, 2012-10-18 19:43:01]

Change committed as 162763