Remove ZLib codec support from chromoting host and client.

Remove ZLib codec support from chromoting host and client.

We were not using ZLIB codec anyway, so there is no reason to keep it around.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162635

[Wez, 2012-10-17 22:25:16]

lgtm

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_decoder_v...
File remoting/codec/video_decoder_verbatim.h (right):

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_decoder_v...
remoting/codec/video_decoder_verbatim.h:14: class VideoDecoderVerbatim : public
VideoDecoder {
nit: Add a comment explaining what this class does.

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
File remoting/codec/video_encoder_verbatim.cc (right):

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.cc:80: // Just to the next row when we've
reached the end of the current row.
nit: Just -> Move

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
File remoting/codec/video_encoder_verbatim.h (right):

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:15: // without compression.
nit: Clarify the format we mean by "verbatim", e.g. ARGB row-based.

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:21: void SetMaxPacketSize(int size);
nit: Clarify what this is for.

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:33: // Marks a packet as the first in a
series of rectangle updates.
nit: How is |rect| used?

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:36: // Retrieves a pointer to the output
buffer in |update| used for storing the
What is |update|?

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:40: // Submit |message| to |callback_|.
nit: |message| -> |packet|

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:49: int packet_size_;
nit: max_packet_size_

[Sergey Ulanov, 2012-10-18 01:09:52]

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_decoder_v...
File remoting/codec/video_decoder_verbatim.h (right):

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_decoder_v...
remoting/codec/video_decoder_verbatim.h:14: class VideoDecoderVerbatim : public
VideoDecoder {
On 2012/10/17 22:25:16, Wez wrote:
> nit: Add a comment explaining what this class does.

Done.

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
File remoting/codec/video_encoder_verbatim.cc (right):

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.cc:80: // Just to the next row when we've
reached the end of the current row.
On 2012/10/17 22:25:16, Wez wrote:
> nit: Just -> Move

Changed to "Jump"

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
File remoting/codec/video_encoder_verbatim.h (right):

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:15: // without compression.
On 2012/10/17 22:25:16, Wez wrote:
> nit: Clarify the format we mean by "verbatim", e.g. ARGB row-based.

Done.

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:21: void SetMaxPacketSize(int size);
On 2012/10/17 22:25:16, Wez wrote:
> nit: Clarify what this is for.

Done.

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:33: // Marks a packet as the first in a
series of rectangle updates.
On 2012/10/17 22:25:16, Wez wrote:
> nit: How is |rect| used?

Done.

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:36: // Retrieves a pointer to the output
buffer in |update| used for storing the
On 2012/10/17 22:25:16, Wez wrote:
> What is |update|?

That was old stale comment from row_based encoder. Fixed.

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:40: // Submit |message| to |callback_|.
On 2012/10/17 22:25:16, Wez wrote:
> nit: |message| -> |packet|

Done.

http://codereview.chromium.org/11195029/diff/1/remoting/codec/video_encoder_v...
remoting/codec/video_encoder_verbatim.h:49: int packet_size_;
On 2012/10/17 22:25:16, Wez wrote:
> nit: max_packet_size_

Done.

[commit-bot: I haz the power, 2012-10-18 01:10:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11195029/6001

[commit-bot: I haz the power, 2012-10-18 03:26:54]

Change committed as 162635