Allow users of git cl to disable git copy detection entirely.

Allow users of git cl to disable git copy detection entirely.

Depends on rietveld cl: https://codereview.appspot.com/6726050/
BUG=155511
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163092

[M-A Ruel, 2012-10-16 22:38:09]

https://codereview.chromium.org/11195012/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/11195012/diff/1/git_cl.py#newcode93
git_cl.py:93: 
2 lines between file-level symbols

https://codereview.chromium.org/11195012/diff/1/git_cl.py#newcode117
git_cl.py:117: '--find-copies', action='store_true', default=None,
default=None is redundant with default's default value.

https://codereview.chromium.org/11195012/diff/1/git_cl.py#newcode120
git_cl.py:120: '--no-find-copies', action='store_false', dest='find_copies',
git-cl doesn't have --foo --no-foo arguments. Just keep --no-find-copies.

https://codereview.chromium.org/11195012/diff/1/git_cl.py#newcode204
git_cl.py:204: similarity_options = ['-M', '-M']
'-M%d' % similarity.

[iannucci, 2012-10-16 22:57:14]

Fixed spacing and bug.

https://chromiumcodereview.appspot.com/11195012/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/11195012/diff/1/git_cl.py#newcode120
git_cl.py:120: '--no-find-copies', action='store_false', dest='find_copies',
On 2012/10/16 22:38:09, Marc-Antoine Ruel wrote:
> git-cl doesn't have --foo --no-foo arguments. Just keep --no-find-copies.

The reason I did this is so that you can un-set it, because it's sticky on the
branch. I would make it one arg which takes True/False, but optparse doesn't
have a straight forward way to do that (though I can obviously do that if
necessary)

https://chromiumcodereview.appspot.com/11195012/diff/1/git_cl.py#newcode204
git_cl.py:204: similarity_options = ['-M', '-M']
On 2012/10/16 22:38:09, Marc-Antoine Ruel wrote:
> '-M%d' % similarity.

Of course I miss out on the entire point of doing it this way :)

It occurs to me that 'find renames harder' doesn't really make sense, given how
git does this detection. However, git's help does mention it so I guess that's a
reason to repeat -M...

[M-A Ruel, 2012-10-16 23:31:27]

https://chromiumcodereview.appspot.com/11195012/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/11195012/diff/1/git_cl.py#newcode120
git_cl.py:120: '--no-find-copies', action='store_false', dest='find_copies',
On 2012/10/16 22:57:14, iannucci wrote:
> On 2012/10/16 22:38:09, Marc-Antoine Ruel wrote:
> > git-cl doesn't have --foo --no-foo arguments. Just keep --no-find-copies.
> 
> The reason I did this is so that you can un-set it, because it's sticky on the
> branch. I would make it one arg which takes True/False, but optparse doesn't
> have a straight forward way to do that (though I can obviously do that if
> necessary)

Ok, sorry I missed it.

https://chromiumcodereview.appspot.com/11195012/diff/1/git_cl.py#newcode204
git_cl.py:204: similarity_options = ['-M', '-M']
On 2012/10/16 22:57:14, iannucci wrote:
> On 2012/10/16 22:38:09, Marc-Antoine Ruel wrote:
> > '-M%d' % similarity.
> 
> Of course I miss out on the entire point of doing it this way :)
> 
> It occurs to me that 'find renames harder' doesn't really make sense, given
how
> git does this detection. However, git's help does mention it so I guess that's
a
> reason to repeat -M...

Errr, there's not really a point in specifying -M twice, I'm not sure why I
recommended that anyhow. And the doc doesn't refer to use -M twice anymore.

https://chromiumcodereview.appspot.com/11195012/diff/6001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/11195012/diff/6001/git_cl.py#newcode120
git_cl.py:120: '--find-copies', action='store_true', default=None,
Remove default=None

[iannucci, 2012-10-17 20:25:08]

Should be all fixed now

[M-A Ruel, 2012-10-17 20:29:27]

lgtm, I'll try to commit the other patch soon.

https://codereview.chromium.org/11195012/diff/7003/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/11195012/diff/7003/git_cl.py#newcode99
git_cl.py:99: RunGit(['config', '--int', git_key, str(value)])
'%d' % value would help you catch bugs but it's just FYI.

[commit-bot: I haz the power, 2012-10-19 23:11:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/11195012/15011

[commit-bot: I haz the power, 2012-10-19 23:15:27]

Change committed as 163092