Keep track of the first non-ascii word/char to avoid redoing the work.

Keep track of the first non-ascii word/char to avoid redoing the work.

Committed: https://code.google.com/p/v8/source/detail?r=12762

[Toon Verwaest, 2012-10-18 13:51:47]

PTAL.

[Yang, 2012-10-18 14:46:22]

LGTM with comments.

https://chromiumcodereview.appspot.com/11194053/diff/1/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/11194053/diff/1/src/heap.cc#newcode4431
src/heap.cc:4431: const char* non_ascii_start,
Maybe it's cleaner to pass non_ascii_start as string index and not as an address
pointing into the backing store? You need that index anyways.

https://chromiumcodereview.appspot.com/11194053/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/11194053/diff/1/src/objects.h#newcode7416
src/objects.h:7416: static inline const char* NonAsciiStart(const char* chars,
int length) {
Please add a comment on what the return value is (it may be a multiple of
sizeof(uintptr_t) depending on the ifdef and not the exact index of the first
char!)

[Toon Verwaest, 2012-10-18 15:06:56]

Addressed comments

https://chromiumcodereview.appspot.com/11194053/diff/1/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/11194053/diff/1/src/heap.cc#newcode4431
src/heap.cc:4431: const char* non_ascii_start,
On 2012/10/18 14:46:23, Yang wrote:
> Maybe it's cleaner to pass non_ascii_start as string index and not as an
address
> pointing into the backing store? You need that index anyways.

Done.

https://chromiumcodereview.appspot.com/11194053/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/11194053/diff/1/src/objects.h#newcode7416
src/objects.h:7416: static inline const char* NonAsciiStart(const char* chars,
int length) {
On 2012/10/18 14:46:23, Yang wrote:
> Please add a comment on what the return value is (it may be a multiple of
> sizeof(uintptr_t) depending on the ifdef and not the exact index of the first
> char!)

Done.