Issue 11194026: Flush out IPC for onSuccess() / onSuccess(long long)

Issue 11194026: Flush out IPC for onSuccess() / onSuccess(long long) (Closed)

Created:
8 years, 2 months ago by alecflett

Modified:
8 years, 2 months ago

Reviewers:
dgrogan, jsbell

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Flush out IPC for onSuccess() / onSuccess(long long) BUG=156247 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162482

Patch Set 2 : Remove dead code #

Total comments: 2

Patch Set 3 : Remove unused message #

Patch Set 4 : formatting nit #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -1 line)			Patch
M	content/browser/in_process_webkit/indexed_db_callbacks.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_callbacks.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_dispatcher.h	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
M	content/common/indexed_db/indexed_db_dispatcher.cc	View	1 2 3	2 chunks	+24 lines, -0 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_messages.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dgrogan

http://codereview.chromium.org/11194026/diff/1/content/browser/in_process_webkit/indexed_db_callbacks.h File content/browser/in_process_webkit/indexed_db_callbacks.h (right): http://codereview.chromium.org/11194026/diff/1/content/browser/in_process_webkit/indexed_db_callbacks.h#newcode76 content/browser/in_process_webkit/indexed_db_callbacks.h:76: virtual void onSuccess(); This doesn't seem like it would ...

8 years, 2 months ago (2012-10-17 01:21:00 UTC) #2

alecflett

And this is why we have reviews :) two mistakes canceled each other out... ready ...

8 years, 2 months ago (2012-10-17 16:27:29 UTC) #3

jsbell

lgtm with one entry that can be removed, and one formatting nit http://codereview.chromium.org/11194026/diff/5001/content/common/indexed_db/indexed_db_dispatcher.cc File content/common/indexed_db/indexed_db_dispatcher.cc ...

8 years, 2 months ago (2012-10-17 17:24:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/11194026/1007

8 years, 2 months ago (2012-10-17 17:34:38 UTC) #5

Change committed as 162482

Expand Messages | Collapse Messages