Fix crash bugs of FramePainter.

Fix crash bugs of FramePainter.

Sometimes FramePainter is deleted without its window's OnWindowDestroying, so removing the kSoloWindowFramePainterKey property explicitly at the destructor.
Also this CL adds the checks of painter's frame_ and its non_client_view() since they may be NULL on window destroying timing on test.

BUG=155634
TEST=ash_unittests passed with the new test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162432

[James Cook, 2012-10-16 20:51:46]

LGTM with one optional suggestion.

https://codereview.chromium.org/11194015/diff/1/ash/wm/frame_painter_unittest.cc
File ash/wm/frame_painter_unittest.cc (right):

https://codereview.chromium.org/11194015/diff/1/ash/wm/frame_painter_unittest...
ash/wm/frame_painter_unittest.cc:141: widget.reset();
Maybe after this line assert that the root window property has been cleared?

[Jun Mukai, 2012-10-16 21:11:45]

https://codereview.chromium.org/11194015/diff/1/ash/wm/frame_painter_unittest.cc
File ash/wm/frame_painter_unittest.cc (right):

https://codereview.chromium.org/11194015/diff/1/ash/wm/frame_painter_unittest...
ash/wm/frame_painter_unittest.cc:141: widget.reset();
On 2012/10/16 20:51:46, James Cook (Chromium) wrote:
> Maybe after this line assert that the root window property has been cleared?

Done.

[Jun Mukai, 2012-10-16 21:12:10]

sky, could you also check this?

[sky, 2012-10-16 22:10:05]

LGTM

[commit-bot: I haz the power, 2012-10-17 00:08:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11194015/5001

[commit-bot: I haz the power, 2012-10-17 11:21:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11194015/5001

[commit-bot: I haz the power, 2012-10-17 11:38:01]

Retried try job too often for step(s) compile

[commit-bot: I haz the power, 2012-10-17 15:33:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11194015/5001

[commit-bot: I haz the power, 2012-10-17 16:48:34]

Change committed as 162432