Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 11194003: Test WebRequest attributes and compatible stages (Closed)

Created:
8 years, 2 months ago by vabr (Chromium)
Modified:
8 years, 2 months ago
Reviewers:
battre
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Test WebRequest attributes and compatible stages Testing that WebRequest attributes with incompatible stages cannot be combined in one condition. BUG=112155 TEST=N/A (adding unit-tests only) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc View 1 chunk +33 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vabr (Chromium)
Hi Dominic, Addressing a TODO you assigned to me. Please take a look. Vaclav
8 years, 2 months ago (2012-10-16 16:55:27 UTC) #1
battre
lgtm
8 years, 2 months ago (2012-10-17 07:35:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/11194003/1
8 years, 2 months ago (2012-10-17 07:39:05 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 09:38:49 UTC) #4
Change committed as 162337

Powered by Google App Engine
This is Rietveld 408576698