Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: chrome/browser/about_flags.cc

Issue 11193052: Add flags for new Autofill work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simpler Android code path Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index fef0984c52acf4a7ac4de7992f01ab74f01a692f..2328f6c42fdce737d9c7104c4b57aa1a12917214 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -198,14 +198,17 @@ const Experiment::Choice kAshBootAnimationFunction[] = {
// the top of that file for details) to update the chromeactions.txt file, which
// will enable UMA to record your feature flag.
//
-// After your feature has shipped under a flag, you can locate the metrics
-// under the action name AboutFlags_internal-action-name. Actions are recorded
-// once per startup, so you should divide this number by AboutFlags_StartupTick
-// to get a sense of usage. Note that this will not be the same as number of
-// users with a given feature enabled because users can quit and relaunch
-// the application multiple times over a given time interval.
-// TODO(rsesek): See if there's a way to count per-user, rather than
-// per-startup.
+// After your feature has shipped under a flag, you can locate the metrics under
+// the action name AboutFlags_internal-action-name. Actions are recorded once
+// per startup, so you should divide this number by AboutFlags_StartupTick to
+// get a sense of usage. Note that this will not be the same as number of users
+// with a given feature enabled because users can quit and relaunch the
+// application multiple times over a given time interval. The dashboard also
+// shows you how many (metrics reporting) users have enabled the flag over the
+// last seven days. However, note that this is not the same as the number of
+// users who have the flag enabled, since enabling the flag happens once,
+// whereas running with the flag enabled happens until the user flips the flag
+// again.
// To add a new experiment add to the end of kExperiments. There are two
// distinct types of experiments:
@@ -969,6 +972,20 @@ const Experiment kExperiments[] = {
kOsAll,
SINGLE_VALUE_TYPE(switches::kCrashOnGpuHang)
},
+ {
+ "enable-new-autofill-ui",
+ IDS_FLAGS_ENABLE_NEW_AUTOFILL_UI_NAME,
+ IDS_FLAGS_ENABLE_NEW_AUTOFILL_UI_DESCRIPTION,
+ kOsWin | kOsLinux,
+ SINGLE_VALUE_TYPE(switches::kEnableNewAutofillUi)
+ },
+ {
+ "enable-new-autofill-heuristics",
+ IDS_FLAGS_ENABLE_NEW_AUTOFILL_HEURISTICS_NAME,
+ IDS_FLAGS_ENABLE_NEW_AUTOFILL_HEURISTICS_DESCRIPTION,
+ kOsAll,
+ SINGLE_VALUE_TYPE(switches::kEnableNewAutofillHeuristics)
+ },
};
const Experiment* experiments = kExperiments;

Powered by Google App Engine
This is Rietveld 408576698