Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 11193022: Remove scratch register requirement from LoadInstanceDescriptors on arm and mips. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1119 matching lines...) Expand 10 before | Expand all | Expand 10 after
1130 __ b(ne, &fixed_array); 1130 __ b(ne, &fixed_array);
1131 1131
1132 // We got a map in register r0. Get the enumeration cache from it. 1132 // We got a map in register r0. Get the enumeration cache from it.
1133 Label no_descriptors; 1133 Label no_descriptors;
1134 __ bind(&use_cache); 1134 __ bind(&use_cache);
1135 1135
1136 __ EnumLength(r1, r0); 1136 __ EnumLength(r1, r0);
1137 __ cmp(r1, Operand(Smi::FromInt(0))); 1137 __ cmp(r1, Operand(Smi::FromInt(0)));
1138 __ b(eq, &no_descriptors); 1138 __ b(eq, &no_descriptors);
1139 1139
1140 __ LoadInstanceDescriptors(r0, r2, r4); 1140 __ LoadInstanceDescriptors(r0, r2);
1141 __ ldr(r2, FieldMemOperand(r2, DescriptorArray::kEnumCacheOffset)); 1141 __ ldr(r2, FieldMemOperand(r2, DescriptorArray::kEnumCacheOffset));
1142 __ ldr(r2, FieldMemOperand(r2, DescriptorArray::kEnumCacheBridgeCacheOffset)); 1142 __ ldr(r2, FieldMemOperand(r2, DescriptorArray::kEnumCacheBridgeCacheOffset));
1143 1143
1144 // Set up the four remaining stack slots. 1144 // Set up the four remaining stack slots.
1145 __ push(r0); // Map. 1145 __ push(r0); // Map.
1146 __ mov(r0, Operand(Smi::FromInt(0))); 1146 __ mov(r0, Operand(Smi::FromInt(0)));
1147 // Push enumeration cache, enumeration cache length (as smi) and zero. 1147 // Push enumeration cache, enumeration cache length (as smi) and zero.
1148 __ Push(r2, r1, r0); 1148 __ Push(r2, r1, r0);
1149 __ jmp(&loop); 1149 __ jmp(&loop);
1150 1150
(...skipping 1525 matching lines...) Expand 10 before | Expand all | Expand 10 after
2676 // Look for valueOf symbol in the descriptor array, and indicate false if 2676 // Look for valueOf symbol in the descriptor array, and indicate false if
2677 // found. Since we omit an enumeration index check, if it is added via a 2677 // found. Since we omit an enumeration index check, if it is added via a
2678 // transition that shares its descriptor array, this is a false positive. 2678 // transition that shares its descriptor array, this is a false positive.
2679 Label entry, loop, done; 2679 Label entry, loop, done;
2680 2680
2681 // Skip loop if no descriptors are valid. 2681 // Skip loop if no descriptors are valid.
2682 __ NumberOfOwnDescriptors(r3, r1); 2682 __ NumberOfOwnDescriptors(r3, r1);
2683 __ cmp(r3, Operand(0)); 2683 __ cmp(r3, Operand(0));
2684 __ b(eq, &done); 2684 __ b(eq, &done);
2685 2685
2686 __ LoadInstanceDescriptors(r1, r4, r2); 2686 __ LoadInstanceDescriptors(r1, r4);
2687 // r4: descriptor array. 2687 // r4: descriptor array.
2688 // r3: valid entries in the descriptor array. 2688 // r3: valid entries in the descriptor array.
2689 STATIC_ASSERT(kSmiTag == 0); 2689 STATIC_ASSERT(kSmiTag == 0);
2690 STATIC_ASSERT(kSmiTagSize == 1); 2690 STATIC_ASSERT(kSmiTagSize == 1);
2691 STATIC_ASSERT(kPointerSize == 4); 2691 STATIC_ASSERT(kPointerSize == 4);
2692 __ mov(ip, Operand(DescriptorArray::kDescriptorSize)); 2692 __ mov(ip, Operand(DescriptorArray::kDescriptorSize));
2693 __ mul(r3, r3, ip); 2693 __ mul(r3, r3, ip);
2694 // Calculate location of the first key name. 2694 // Calculate location of the first key name.
2695 __ add(r4, r4, Operand(DescriptorArray::kFirstOffset - kHeapObjectTag)); 2695 __ add(r4, r4, Operand(DescriptorArray::kFirstOffset - kHeapObjectTag));
2696 // Calculate the end of the descriptor array. 2696 // Calculate the end of the descriptor array.
(...skipping 1831 matching lines...) Expand 10 before | Expand all | Expand 10 after
4528 *context_length = 0; 4528 *context_length = 0;
4529 return previous_; 4529 return previous_;
4530 } 4530 }
4531 4531
4532 4532
4533 #undef __ 4533 #undef __
4534 4534
4535 } } // namespace v8::internal 4535 } } // namespace v8::internal
4536 4536
4537 #endif // V8_TARGET_ARCH_ARM 4537 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698