Protocol plumbing for audio toggle.

Protocol plumbing for audio toggle.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162637

[rmsousa, 2012-10-17 22:21:24]

Hi Gary,

This is just the plumbing for the toggle (from the webapp's ClientSession.js to
reaching the host's ClientSession.cc).

I'll follow up with the implementation later.

[Sergey Ulanov, 2012-10-17 23:33:02]

LGTM. 
Is there corresponding bug? If yes, then update BUG= please.
I think we also need some way for the host to notify the client that it actually
supports AudioControl message. Otherwise we risk confusing the user with a
control that doesn't work. Alternative (and maybe better) approach is to drop
audio packets on the client side when user pauses audio.

[Jamie, 2012-10-17 23:45:30]

On 2012/10/17 23:33:02, sergeyu wrote:
> LGTM. 
> Is there corresponding bug? If yes, then update BUG= please.
> I think we also need some way for the host to notify the client that it
actually
> supports AudioControl message. Otherwise we risk confusing the user with a
> control that doesn't work. Alternative (and maybe better) approach is to drop
> audio packets on the client side when user pauses audio.

We were hoping not to need any client-side UI, and just hook into tab-mute when
it's available. We wanted to land the plumbing earlier though.

[Sergey Ulanov, 2012-10-17 23:52:06]

On Wed, Oct 17, 2012 at 4:45 PM, <jamiewalch@chromium.org> wrote:

> On 2012/10/17 23:33:02, sergeyu wrote:
>
>> LGTM.
>> Is there corresponding bug? If yes, then update BUG= please.
>> I think we also need some way for the host to notify the client that it
>>
> actually
>
>> supports AudioControl message. Otherwise we risk confusing the user with a
>> control that doesn't work. Alternative (and maybe better) approach is to
>> drop
>> audio packets on the client side when user pauses audio.
>>
>
> We were hoping not to need any client-side UI, and just hook into tab-mute
> when
> it's available. We wanted to land the plumbing earlier though.
>

sgtm


>
>
http://codereview.chromium.**org/11192042/<http://codereview.chromium.org/111...
>

[commit-bot: I haz the power, 2012-10-18 01:11:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmsousa@chromium.org/11192042/1

[commit-bot: I haz the power, 2012-10-18 03:28:02]

Change committed as 162637