Issue 11192008: Set grey text in the omnibox irrespective of the verbatim state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11192008: Set grey text in the omnibox irrespective of the verbatim state. (Closed)

Created:
8 years, 2 months ago by Shishir

Modified:
8 years, 2 months ago

Reviewers:
sreeram

CC:
chromium-reviews, samarth, gideonwald, dominich, David Black, Jered

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Set grey text in the omnibox irrespective of the verbatim state. BUG=155619 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162273

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/instant/instant_controller.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

sreeram

On 2012/10/16 19:08:35, sreeram wrote: > lgtm Could you add a browser test for this?

8 years, 2 months ago (2012-10-16 19:09:26 UTC) #3

Shishir

On 2012/10/16 19:09:26, sreeram wrote: > On 2012/10/16 19:08:35, sreeram wrote: > > lgtm > ...

8 years, 2 months ago (2012-10-16 19:28:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shishir@chromium.org/11192008/1

8 years, 2 months ago (2012-10-16 21:00:05 UTC) #5

Change committed as 162273