Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 11192004: Reland - ash: Add test for maximized app window frame switching (Closed)

Created:
8 years, 2 months ago by James Cook
Modified:
8 years, 2 months ago
Reviewers:
Josh Horwich, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Reland - ash: Add test for maximized app window frame switching When app windows are maximized the normal window frame is replaced with a special AppNonClientFrameViewAura. This adds a test for frame replacement on maximize, restore and minimize. BUG=156093 TEST=added test to browser_test AppNonClientFrameViewAuraTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162382 Reverted for linux_aura build failure: crrev.com/162412 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162503

Patch Set 1 #

Patch Set 2 : fix linux_aura #

Patch Set 3 : fix windows expect_eq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3 lines) Patch
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura_browsertest.cc View 1 2 4 chunks +53 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
James Cook
Josh, PTAL. An intro to the wonderful world of window frames. :-)
8 years, 2 months ago (2012-10-16 17:49:08 UTC) #1
Josh Horwich
On 2012/10/16 17:49:08, James Cook (Chromium) wrote: > Josh, PTAL. An intro to the wonderful ...
8 years, 2 months ago (2012-10-16 21:47:31 UTC) #2
James Cook
Scott, can I get OWNERS approval for this test?
8 years, 2 months ago (2012-10-16 22:13:24 UTC) #3
sky
LGTM
8 years, 2 months ago (2012-10-16 23:12:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11192004/1
8 years, 2 months ago (2012-10-16 23:37:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11192004/1
8 years, 2 months ago (2012-10-17 11:19:25 UTC) #6
commit-bot: I haz the power
Change committed as 162382
8 years, 2 months ago (2012-10-17 13:21:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11192004/1007
8 years, 2 months ago (2012-10-17 18:09:11 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 20:10:56 UTC) #9
Change committed as 162503

Powered by Google App Engine
This is Rietveld 408576698