components/history/core/browser/history_backend.cc - Issue 1119163003: Save large icons to a new LARGE_ICON type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend.cc

Issue 1119163003: Save large icons to a new LARGE_ICON type Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yet more clarifying comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_backend.cc

diff --git a/components/history/core/browser/history_backend.cc b/components/history/core/browser/history_backend.cc

index faf00c6db8293356065862bd9fdc5e72a72ba4c8..eab447265c2ed556131284199c72556321f0f82e 100644

--- a/components/history/core/browser/history_backend.cc

+++ b/components/history/core/browser/history_backend.cc

@@ -1844,6 +1844,7 @@ void HistoryBackend::UpdateFaviconMappingsAndFetchImpl(

DCHECK(!page_url || icon_types == favicon_base::FAVICON ||

icon_types == favicon_base::TOUCH_ICON ||

icon_types == favicon_base::TOUCH_PRECOMPOSED_ICON ||

+ icon_types == favicon_base::LARGE_ICON ||

icon_types ==

(favicon_base::TOUCH_ICON | favicon_base::TOUCH_PRECOMPOSED_ICON));

bitmap_results->clear();